Scheduling file backup error with users have sudo authority

[jiaopengju]

When scheduling file backup, it will fail with error.

2017-05-03 04:52:47.419 10261 ERROR freezer.main [-] Error while creating directory /var/lib/freezer/mount_2b259bac9f0d4a159471b1200a50c33e: [Errno 13] Permission denied: '/var/lib/freezer/mount_2b259bac9f0d4a159471b1200a50c33e'
2017-05-03 04:52:47.419 10261 ERROR freezer.main Traceback (most recent call last):
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/main.py", line 217, in main
2017-05-03 04:52:47.419 10261 ERROR freezer.main freezer_main(backup_args)
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/main.py", line 114, in freezer_main
2017-05-03 04:52:47.419 10261 ERROR freezer.main return run_job(backup_args, storage)
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/main.py", line 127, in run_job
2017-05-03 04:52:47.419 10261 ERROR freezer.main response = freezer_job.execute()
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/job.py", line 153, in execute
2017-05-03 04:52:47.419 10261 ERROR freezer.main backup_level = self.backup(app_mode)
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/job.py", line 207, in backup
2017-05-03 04:52:47.419 10261 ERROR freezer.main snapshot_taken = snapshot.snapshot_create(self.conf)
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/snapshot/snapshot.py", line 46, in snapshot_create
2017-05-03 04:52:47.419 10261 ERROR freezer.main return lvm.lvm_snap(backup_opt_dict)
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/snapshot/lvm.py", line 124, in lvm_snap
2017-05-03 04:52:47.419 10261 ERROR freezer.main utils.create_dir(backup_opt_dict.lvm_dirmount)
2017-05-03 04:52:47.419 10261 ERROR freezer.main File "/opt/stack/freezer/freezer/utils/utils.py", line 69, in create_dir
2017-05-03 04:52:47.419 10261 ERROR freezer.main raise Exception(err)
2017-05-03 04:52:47.419 10261 ERROR freezer.main Exception: Error while creating directory /var/lib/freezer/mount_2b259bac9f0d4a159471b1200a50c33e: [Errno 13] Permission denied: '/var/lib/freezer/mount_2b259bac9f0d4a159471b1200a50c33e'
2017-05-03 04:52:47.419 10261 ERROR freezer.main
2017-05-03 04:52:47.420 10261 CRITICAL freezer.main [-] End freezer agent process unsuccessfully
2017-05-03 04:52:47.420 10261 CRITICAL freezer.main [-] Critical Error: Error while creating directory /var/lib/freezer/mount_2b259bac9f0d4a159471b1200a50c33e: [Errno 13] Permission denied: '/var/lib/freezer/mount_2b259bac9f0d4a159471b1200a50c33e'

Method of reproducing the error:
1. freezer-scheduler runs with user named 'stack' who has sudo authority.
2. Create a job with command 'freezer job-create --file job-file.conf --client xxxx'
   [stack@ceph36 jiaopengju]$ cat job-file.conf
{
    "user_id": "0e96b4316a9e451dafb6ebdbf9e87fa4",
    "job_id": "6a57b3fdfdf845b4a08e16e81a185bc5",
    "job_schedule": {
        "status": "running",
        "time_started": 1493724157,
        "time_created": 1493724100,
        "time_ended": -1,
        "result": "",
        "current_pid": 8653,
        "event": ""
    },
    "client_id": "c1e8a68f24a8481ab2591eec5dc8c17a_ceph36",
    "job_actions": [
        {
            "user_id": "0e96b4316a9e451dafb6ebdbf9e87fa4",
            "freezer_action": {
                "backup_name": "fstest",
                "container": "/opt/stack/fstest",
                "path_to_backup": "/opt/stack/jiaopengju",
                "storage": "local",
                "snapshot": "true",
                "mode": "fs",
                "action": "backup"
            },
            "action_id": "ef2eed0df90d4cdb9f66ca8454a60a6e"
        }
    ],
    "description": "backup-fs"
}

[jiaopengju (pj-jiao)]

I think we should add sudo authority when doing lvm snapshot, such as what cinder project do.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jiao Pengju (<email address hidden>) on branch: master
Review: https://review.openstack.org/462472