Avoid using deprecated opt in Web-UI

[Kent Wu]

We're running into issue in Pike release. The freezer job created through Horizon UI runs into failure status. It's due to a deprecated opt 'os_auth_ver'[1] gets passed into Freezer[2] and causes grief on oslo.config[3] while overriding the value.

Here's the command line way to reproduce the error on Freezer end:
>>> from freezer.common import config as freezer_config
>>> freezer_config.config()
>>> freezer_config.CONF.set_override('os_auth_ver', '2')
Config option None.os_auth_ver is deprecated. Use option DEFAULT.os-identity-api-version instead.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/debtcollector/removals.py", line 261, in wrapper
    return f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/oslo_config/cfg.py", line 2402, in __inner
    result = f(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/oslo_config/cfg.py", line 2727, in set_override
    opt_info = self._get_opt_info(name, group)
  File "/usr/lib/python2.7/site-packages/oslo_config/cfg.py", line 3115, in _get_opt_info
    return opts[opt_name]
KeyError: 'os-identity-api-version'
>>>

[1] https://git.openstack.org/cgit/openstack/freezer/tree/freezer/common/config.py#n346
[2] https://git.openstack.org/cgit/openstack/freezer/tree/freezer/common/config.py#n569
[3] https://git.openstack.org/cgit/openstack/oslo.config/tree/oslo_config/cfg.py?h=refs/heads/master#n3144

[Kent Wu (mimic1983)]

Here's the proposed fix:
https://review.openstack.org/#/c/576657/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/576657
Committed: https://git.openstack.org/cgit/openstack/freezer-web-ui/commit/?id=40a07a0e003961b26a1a87172f796f75a215b917
Submitter: Zuul
Branch: master

commit 40a07a0e003961b26a1a87172f796f75a215b917
Author: Kent Wu <email address hidden>
Date: Tue Jun 19 16:10:24 2018 -0600

    Avoid using deprecated opt in Web-UI

    Use new opt instead of deprecated opt to avoid KeyError.

    Change-Id: I9bff33eac9c756afb571f81824a8a3242477f321
    Closes-Bug: #1777705

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/579713

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/579713
Committed: https://git.openstack.org/cgit/openstack/freezer-web-ui/commit/?id=a712fd4fe7cade6caff2ea0da9272abd1e4d5fdd
Submitter: Zuul
Branch: stable/pike

commit a712fd4fe7cade6caff2ea0da9272abd1e4d5fdd
Author: Kent Wu <email address hidden>
Date: Tue Jun 19 16:10:24 2018 -0600

    Avoid using deprecated opt in Web-UI

    Use new opt instead of deprecated opt to avoid KeyError.

    Change-Id: I9bff33eac9c756afb571f81824a8a3242477f321
    Closes-Bug: #1777705
    (cherry picked from commit 40a07a0e003961b26a1a87172f796f75a215b917)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/freezer-web-ui 7.0.0 release.

[alpha23 (alpha23)]

Was this fixed in Queens as well? I'm receiving the same error:

2019-03-07 18:25:42.355 27202 WARNING oslo_config.cfg [-] Config option None.os_auth_ver is deprecated. Use option DEFAULT.os-identity-api-version instead.
2019-03-07 18:25:42.356 27202 ERROR freezer.main [-] 'os-identity-api-version': KeyError: 'os-identity-api-version'
2019-03-07 18:25:42.356 27202 ERROR freezer.main Traceback (most recent call last):
2019-03-07 18:25:42.356 27202 ERROR freezer.main File "/usr/local/lib/python2.7/dist-packages/freezer/main.py", line 235, in main
2019-03-07 18:25:42.356 27202 ERROR freezer.main backup_args = freezer_config.get_backup_args()
2019-03-07 18:25:42.356 27202 ERROR freezer.main File "/usr/local/lib/python2.7/dist-packages/freezer/common/config.py", line 570, in get_backup_args
2019-03-07 18:25:42.356 27202 ERROR freezer.main CONF.set_override(config_key, conf.default[config_key])
2019-03-07 18:25:42.356 27202 ERROR freezer.main File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2436, in __inner
2019-03-07 18:25:42.356 27202 ERROR freezer.main result = f(self, *args, **kwargs)
2019-03-07 18:25:42.356 27202 ERROR freezer.main File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2755, in set_override
2019-03-07 18:25:42.356 27202 ERROR freezer.main opt_info = self._get_opt_info(name, group)
2019-03-07 18:25:42.356 27202 ERROR freezer.main File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 3128, in _get_opt_info
2019-03-07 18:25:42.356 27202 ERROR freezer.main return opts[opt_name]
2019-03-07 18:25:42.356 27202 ERROR freezer.main KeyError: 'os-identity-api-version'
2019-03-07 18:25:42.356 27202 ERROR freezer.main
2019-03-07 18:25:42.360 27202 CRITICAL freezer.main [-] End freezer agent process unsuccessfully
2019-03-07 18:25:42.361 27202 CRITICAL freezer.main [-] Critical Error: 'os-identity-api-version'

[Kent Wu (mimic1983)]

Unfortunately, no. We only cherry-pick to stable/pike.

[alpha23 (alpha23)]

@Kent Wu, why are you only cherry-picking to stable/pike? Did the freezer team decided not to support Queens and I missed the memo? I thought in order to be an Openstack project, there was some type of quality controls in place so that users were not using buggy code with incomplete documentation. Realize that buggy code and incomplete documentation leads to wasted time for many.