Guide data and selections aren't aged equally

Bug #538631 reported by Arisian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
FreeGuide-TV
In Progress
Wishlist
Unassigned

Bug Description

SER data (programmes) and Selections (reminder-alarm) use different values to delete old records.

Revision history for this message
Arisian (mmclagan) wrote :

The following consolidates the aging of history into a single place. It does not have a UI to set the value, but it is stored in the configuration.

What I don't like about this is it should *probably* use the start of day time from the configuration rather than days from "now" to age the records but I followed the code as it was.

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Thank you. I will take a look as soon as I get a chance.

Changed in freeguide-tv:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Arisian (mmclagan) wrote :

I guess it would help if I added the *RIGHT* patch...

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

This patch looks very good - I've attached a version that applies cleanly to the latest code.

I don't want to commit it until I've got some tests for it, though. It should be possible to make file/selection deletions happen in a virtual method and then in the test make a subclass that implements that method to keep track of what would have happened, and confirm that it works as expected.

Changed in freeguide-tv:
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.