Episode numbers incorrect.

[rco133]

Hi.

I believe that the episode numbers are incorrectly imported when using xmltv as input.

There are examples from my xmltv file:

<episode-num system="xmltv_ns"> . 78 . </episode-num>
<episode-num system="xmltv_ns"> . 7 . </episode-num>
<episode-num system="xmltv_ns"> . 13/14 . </episode-num>

If I import a file with these data into FreeGuide the episode numbers are shows as:

78
7
13/14

If I read the DTD specification that is not correct. The actual episode numbers in the aboce cases should be:

79
8
14/14

I read the DTD as if the program using the data is supposed to add 1 to get the correct episode number when xmltv_ns is used. But Maybe I read it or understand it wrong.

The DTD can be seen here: http://xml.coverpages.org/XMLTV-DTD-20021210.html

rco133

[Andy Balaam (mail-artificialworlds)]

Yes, at the moment we simply dump the raw string in the XML into the UI. We should parse this properly and display it in a more friendly format.

[Arisian (mmclagan)]

This patch reads the episode numbers for both xmltv_ns and dd_progid, updating the part numbers. It deals with missing numbers and optional whitespace.

It corrects a couple of shortcomings of the previously posted patches and successfully imported over 400,000 programs from scheduledirect.

[Andy Balaam (mail-artificialworlds)]

I've attached a patch that contains a couple of tests to demonstate what I'm looking for, and set up the test framework. I've also made some other small changes, mostly to support the tests, and also some to support my tastes :) and the standard code layout.

Please could you add a more assertions for any corner cases you can think of for xmltv_ns, and add meaningful tests for dd_progid, based on data you can find in the DD xml.

Thanks, Andy