There is no need for FreeGuide to ask you which browser you use

Bug #184160 reported by Andy Balaam
2
Affects Status Importance Assigned to Milestone
FreeGuide-TV
Fix Released
Medium
Andy Balaam

Bug Description

During the First Time Wizard, FreeGuide asks which browser you are using.

Instead, it should use the mechanism within Java to launch a URL when it wants to open a browser window.

Changed in freeguide-tv:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Dan Watkins (oddbloke) wrote :

I'll have a go at this. Unless I'm mistaken, it's not going to be possible to do this with 100% certainty. My current thinking is that I'll:
 - attempt to use the new Desktop API, introduced in Java 6 (http://java.sun.com/developer/technicalArticles/J2SE/Desktop/javase6/desktop_api/)
 - attempt to use Mac OS or Windows defaults, or 'xdg-open' if on GNU/Linux
 - fallback to asking what browser they would like to use

An alternative to this last step would be to go through a list of browsers (i.e. Firefox, Konqueror, Epiphany etc.) and try to launch them until one works.

Changed in freeguide-tv:
assignee: nobody → daniel-thewatkins
status: Confirmed → In Progress
Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Great news! Your plan sounds excellent. I think I prefer falling back onto asking the user rather than "trying them all" since e.g. a GNOME user might have Konqueror installed, but certainly wouldn't want it to be used by FreeGuide.

One other thing to think about: a Debian or Ubuntu user whose system is not modern enough to have xdg-open would have the Debian "sensible-browser" command instead...

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Any progress? Thanks, Andy

Revision history for this message
Dan Watkins (oddbloke) wrote :

Afraid not. I'm happy to give up the bug if someone else wants to work on it, but hope to continue working on it Real Soon Now.

Dan

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Real Soon Now sounds ideal :)

Feel free to keep the bug - I don't think I'll get to it any time soon.

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Looks like Daniel is not going to have time to fix this at the moment, so changing status back to Confirmed in case someone else wants to have a go.

Changed in freeguide-tv:
status: In Progress → Confirmed
Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Since we now require Java 1.6 or greater, we can simply use the Java api to launch a browser.

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

I am working on this. It will fall back to the old way if the Java Desktop API fails, but the browser command-line option will become a hidden feature.

Changed in freeguide-tv:
milestone: none → 0.11
status: Confirmed → In Progress
Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

A hidden config option, I mean.

Changed in freeguide-tv:
assignee: Daniel Watkins (daniel-thewatkins) → Andy Balaam (mail-artificialworlds)
Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

I committed the last bit of the fix for this tonight, so hopefully it will now work as expected - use the Java Desktop API, or fall back on a sensible choice of browser if that doesn't work.

Changed in freeguide-tv:
status: In Progress → Fix Committed
Changed in freeguide-tv:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.