Ask for dark theme

Bug #1058698 reported by Camilo Higuita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Foto
Fix Committed
Wishlist
Erasmo Marín

Bug Description

This is more of a blueprint. I think Foto would look a lot more integrated with the gnome desktop and so with Pantheon if it made use of the dark theme, like eog and terminal and other apps does in Pantheon and Gnome 3.6.

Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

I have no skills at theming, but I will consider your idea. By now, there is not an official elementary dark theme, so I will wait for that.

Changed in foto:
importance: Undecided → Wishlist
Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

I have added a dark background to album grid view, I would like to have your opinion. Thanks.

Revision history for this message
Camilo Higuita (kxmylo) wrote :

It looks a lot better with the dark background. I believe it looked even better with a textured background: http://screencloud.net/v/tLtW

I still strongly think Foto should ask for dark theme, as other apps do, like Pantheon Terminal, EOG, Audience etc... although elementary won't implement the dark theme for Luna it will be implement for Luna+, it even exists e a branch for it :
https://code.launchpad.net/~tombeckmann/egtk/dark-theme

Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

Yes, I know, I'm using that branch now, but it have a lot of bugs, is not usable at all.

Dan said that he was not going to make a dark theme until some modifications with theming in the next version of gnome.

I will probably add an option to use dark theme, so, user can choose.

Check line 48 in foto.vala, if you uncomment this option, you can use dark theme, but as I show you in the screenshot, it have lot's of problems.

Revision history for this message
Camilo Higuita (kxmylo) wrote :

I see. It was pretty usable with Pantheon terminal and eog... but i'm aware that they didn't finish it cause they will have to rewrite the theme for the gnome 3.6 version. It is still, i think , a good a idea for the app to ask for the dark theme in case the theme being used supports dark theme like the Orion theme.

Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

I have added the option to the prefferences dialog. I think this is the first app that allows the user to choose to use or not dark theme (?).

Default value is "false", but when the elementary dark theme is ready, it will be "true".

Changed in foto:
assignee: nobody → Erasmo Marín (erasmo-marin)
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.