Footnote shouldn't hardcode years

Bug #925085 reported by Andrea Basso
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Footnote
Fix Committed
Undecided
Tom Beckmann

Bug Description

Right now years are hardcoded, while it should detect the first and last year of notes.

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Uhm... could you explain this a bit further? :/

Revision history for this message
Andrea Basso (voluntatefaber) wrote :

In the date filter bar you can select the year you want to see notes from.
Looking at the code I saw right now 2011 and 2012 are hardcoded, but Footnote should search the first note created and the last one and use those years. So 2011 shouldn't be showed if I haven't any note from 2011 (and maybe even remove the year selector if there is only one year) and we don't need to add 2013 in a year.

Revision history for this message
Harvey Cabaguio (harveycabaguio) wrote :

I agree completely.

Changed in footnote:
assignee: nobody → Tom Beckmann (tombeckmann)
status: New → Fix Committed
Revision history for this message
Kurt Smolderen (kurt.smolderen) wrote :

Although marked as 'Fix committed', how does it come footnote.vala from trunk still contains hardcoded references to 2012:

[...]
public FootnoteApp (){
    month = -1;
    year = 2012;
[...]

These hardcoded years make notes from this year (2013 as I'm writing this) are hidden by default...

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Thanks kurt, that's fixed now as well.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.