Untested tests get through to release

Bug #894770 reported by Tim Bond
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fluidity
Fix Released
Medium
Tim Bond

Bug Description

At present we have 'special' tests in the trunk which are not actually run by buildbot, many of which have bitrotted significantly.

I propose that tests which are not actually being run (and thus tested!) should not be in the trunk and should be removed.

If you object to this happening, please say so. Otherwise, I will treat this as a bug and resolve it by removing untested tests before 4.1.1.

(If you support this proposal, please say so!)

Related branches

Revision history for this message
Rhodri Davies (rhodri-davies) wrote :

Hi Tim,

Would it be possible to have a list of the untested tests so that developers who are keen to keep them in the trunk can modify them accordingly?

Rhod

Revision history for this message
Simon Mouradian (mouradian) wrote :

explicit-hyperc-shear-adapt-long
explicit-hyperc-shear-long
grand_banks_tsunami-gmsh
grand_banks_tsunami-terreno
Lag_paths_2d_moving_in_circles_in_square_domain
lituya_bay_parallel_debug-gmsh
lock_exchange_2d_adapt_large_number_Lag_dets_serial_checkp
lock_exchange_2d_adapt_large_number_Lag_dets_serial
mms_burgers_p0_steady
mms_ns_cg_steady_stress
mms_ns_dg_steady_full
mms_ns_p2lp1_supg_steady_compressible_partialstress
mms_tracer_cg_advdiff_excludemass_3d
mms_tracer_cg_advdiff_steady
mms_tracer_cg_supg_advdiff_steady
mms_tracer_P1dg_br_diff_steady_3d
mms_tracer_P1dg_br_diff_steady_quasi3d
mms_tracer_P1dg_cdg_diff_steady_3d_cjc
mms_tracer_P1dg_cdg_diff_steady_quasi3d
mphase_tephra_settling_3d
mphase_tephra_settling_salinity
OODC_3d_Jones_Marshal_Lag_particles_parallel
OODC_3d_Jones_Marshal_Lag_particles_serial
square-convection-1e6
Stokes_mms_cg_p2p1_3d_periodic
Stokes_mms_cg_p2p1_3d
Stokes_mms_cg_p2p1_3d_struct
Stokes_mms_cg_p2p1_3d_tdepvisc

Revision history for this message
Brendan Tollit (btollit) wrote :

and there should also be a check for tests that have no .xml file! Such as

mphase_test1_2d

Revision history for this message
Simon Mouradian (mouradian) wrote :

I should mention my list is only of untested longtests.

Revision history for this message
Christian Jacobs (ctjacobs) wrote :

mphase_tephra_settling_salinity has been updated and changed to 'long'. Tim - could you schedule this test on buildbot please?

Tim Bond (timothy-bond)
Changed in fluidity:
importance: Undecided → Medium
assignee: nobody → Tim Bond (timothy-bond)
Revision history for this message
Tim Bond (timothy-bond) wrote :

Christian - that's now on buildbot

Missing .xml files are:

avlesen
bdfm1_kelvin_wave
div_conforming_projection
gyre_baroclinic
hh_rt0_square
hybridized_balance
kelvin_wave
mphase_test1_2d
parallel_adaptivity
parallel_p1_consistent_interpolation_2p1d
parallel_p1_consistent_interpolation_3d
parallel_p2_consistent_interpolation_2p1d
parallel_p2_consistent_interpolation_3d
parallel_region_ids_2p1d
parallel_region_ids_3d
raleigh-bernard_2d_dg
sw_sphere
taylor-vortex-dg
test_advection_diffusion
test_dispersion_relation
tracer_inflow_2d_dg

Special-length tests are:

2d_periodic_p1p1_streamfunction
backward_facing_step_3d
backward_facing_step_3d_zoltan_sam_small
balance-pressurebarotropic_double_gyre
biology-nophysics
biology-nophysics_checkpoint
channel-flow-p0p1
diffusion_2d_p0_adaptive_serial
driven_cavity_2d_dg
gls-StationPapa-biology
grandy_projectiongravity-col-p0p1-weak-adaptive-parallel
gravity-col-p0p1-weak-adaptive-serial
gyre_layered
hyperc-shear-moving-meshhyperc-shear-moving-mesh-divfreehyperc-shear-moving-mesh-divfree-pseudolagrangianIGW
just-coarsen-parallel
lock_exchange_2d_cg_parallel
lock_exchange_2d_dg
lock_exchange_2d_dg_p0_p1_adaptive_parallel
lock_exchange_2d_dg_p1dg_p2_adaptive_parallel
lock_exchange_2d_dg_quad
mmat-gravity-col-p0p1-weak-adaptive-parallel
mmat-gravity-col-p0p1-weak-adaptive-serial
mmat-gravity-col-p1bp1cv-2d
mmat-interpolationmmat-interpolation-2d-parallelmmat-interpolation-lumpedmmat-interpolation-pseudo2d-parallelmmat-interpolation-represcribemmat-meniscus
mmat-square-blob
mms_tracer_fv_diff_excludemass_excludeadv
moving_internal_wave_cg
moving_lock_exchange_2d_dg
mphase_rising_body
parallel_periodic_adaptivity
periodic_2plus1_adaptivity_parallel
periodic_advection_1d_cg
periodic_channel_convergence
preditor_prey_0d
prescribed_adaptivityprescribed_diffusivity
region_id_parallel
rossby_equatorial_soliton_dg
shallow_water_optimisation_2d
shallow_water_optimisation_bounds
shallow_water_optimisation_sphere
square-convection-parallelsquare-convection-parallel-trivialsquare-dg
Stokes_mms_p0p1cv
Stokes_square_convection_1e4_p2p1_adaptive_parallel
su_stabilisationsw_fsphere
test_coupler
test_shallow_water
tidal_channel_2d
tracer_gyre_dg
viscosity_2d_p0_adaptive_serial
water_collapse_pseudo2dadapt

Revision history for this message
Tim Bond (timothy-bond) wrote :

Hmm, something went wrong there!

mmat-interpolationmmat-interpolation-2d-parallelmmat-interpolation-lumpedmmat-interpolation-pseudo2d-parallelmmat-interpolation-represcribemmat-meniscus

should have read:

mmat-meniscus

Revision history for this message
Christian Jacobs (ctjacobs) wrote :

Thanks Tim. The mphase_rising_body test case has now been changed from 'special' to 'short'. Updates for mphase_tephra_settling_3d to come...

Revision history for this message
Patrick Farrell (pefarrell) wrote :

I support this proposal strongly. "special" tests had a good reason for existing when we all lived in the one trunk, but now that we have a relatively sane vcs with branching, there is no excuse for them anymore.

Revision history for this message
Jon Hill (jon-hill) wrote :

Agreed. All special tests should be removed from trunk (along with those without XML). If people want to claim them, they can then create a branch that contains that test, fix it, and merge it back to trunk.

Revision history for this message
Tim Bond (timothy-bond) wrote :

Thanks all for input.

With the exception of the test Christian is going to update, untested tests are now removed from the latest revisions of the trunk and longtests. To recover these from pre-removal, use:

lp:fluidity revision 3868
lp:fluidity/longtests revision 2016

Changed in fluidity:
status: New → Fix Committed
Revision history for this message
Christian Jacobs (ctjacobs) wrote :

Updates to mphase_tephra_settling_3d committed. Passes locally. Tim - can you schedule it on buildbot please?

Revision history for this message
Tim Bond (timothy-bond) wrote :

That's now scheduled.

Tim Bond (timothy-bond)
Changed in fluidity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.