Parallel Detector IO

Bug #1262890 reported by Rhodri Davies
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fluidity
Fix Committed
High
Unassigned

Bug Description

I have a very simple test case in a 1x1 2D square domain, with a prescribed horizontal velocity. I have 3 individual lagrangian detectors -- (0.5,0.0), (0.5,0.5), (0.5,1.0).

If I run this case in serial, the positions of these detectors, after each timestep, are output into the .detector file correctly. However, if I run this simulation in parallel, on only 2 cores, this is not the case - the position of the first detector is output correctly, but all other written detector positions are erroneuous.

I have followed individual detector positions through the code, and their positions are updated correctly, implying that this is strictly an issue with parallel detector IO. In other words, a write statement of detector positions at line 2787 of subroutine write_mpi_out in Diagnostic_variables.F90 (I am on the latest trunk version) suggests that the individual detectors have been advected to the correct positions. However, when writting to the .detector file, this information seems to get lost/mangled.

I have attached everything that is required to reproduce this bug (prescribed.flml is the serial case, parallel_prescribed.flml is the 2 processor case). If something is unclear please let me know.

Related branches

Revision history for this message
Rhodri Davies (rhodri-davies) wrote :
Changed in fluidity:
importance: Undecided → High
Revision history for this message
Michael Lange (michael-lange) wrote :

Hi Rhodri,

Thanks for reporting this bug and providing the test case. The problem was that the names of lagrangian detectors were being overwritten during initialisation, causing I/O to fail, which I have fixed in the attached branch (lp:~fluidity-core/fluidity/fix-lagr-detectors).

Hope this helps
Michael

Changed in fluidity:
status: New → Confirmed
Revision history for this message
Rhodri Davies (rhodri-davies) wrote :

Hi Michael,

Thanks for the prompt response and fix. I can confirm that it fixes the bug. Are you happy to propose a merge into trunk? I've looked through your changes and am happy to approve. One suggestion may be to include my test case as a test, to ensure that this isn't broken again...

Best wishes and thanks again,

Rhod

Changed in fluidity:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.