Error checking for diagnostic field dependencies does not work when the diagnostic is dependent on a field that is hidden somewhere in the options tree
Bug #1026041 reported by
Samuel Parkinson
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fluidity |
In Progress
|
Critical
|
Jon Hill |
Bug Description
subroutine diagnostic_
Related branches
lp:~jon-hill/fluidity/diagnostic_check
Ready for review
for merging
into
lp:fluidity
- Stephan Kramer: Needs Fixing
- sam: Pending requested
-
Diff: 554 lines (+382/-51)11 files modifieddiagnostics/Diagnostic_Fields_New.F90.in (+74/-9)
preprocessor/Additional_Field_Locations.F90 (+88/-0)
preprocessor/Makefile.dependencies (+8/-0)
preprocessor/Makefile.in (+2/-2)
preprocessor/Populate_State.F90 (+1/-40)
tests/additional_fields_diagnostics_check/Makefile (+24/-0)
tests/additional_fields_diagnostics_check/additional_fields_diagnostics_check.xml (+33/-0)
tests/additional_fields_diagnostics_check/diagnostics.flml (+115/-0)
tests/additional_fields_diagnostics_check/square.edge (+12/-0)
tests/additional_fields_diagnostics_check/square.ele (+12/-0)
tests/additional_fields_diagnostics_check/square.node (+13/-0)
Changed in fluidity: | |
assignee: | nobody → Samuel Parkinson (s-parkinson11) |
importance: | Undecided → Low |
Changed in fluidity: | |
importance: | Low → Critical |
assignee: | Samuel Parkinson (s-parkinson11) → Jon Hill (jon-hill) |
status: | New → In Progress |
To post a comment you must log in.
I've added a new module that contains such hidden paths, so that populate_state and diagnostic: :check_ options can use these. I've also added a test to check that something hidden under parameterisatio n.prescribed_ diffusivity can be used in a new diagnostic field.