Flickering LEDs in tintramping branch

[Max Power]

Test subject: My NOFET-K9.3 with Ch1 E21A and Ch2 SST20 Deep Red, Andúril r628.

Description:
After having tint-ramped to either only channel one or two (end of the tint ramp, not in auto-tint) the non-actiive channel starts flickering when the button is pressed. This is espechially noticable in lockout when using momentary moonlight.

Reproduction:
Turn on the flashlight
Tint ramp to either only channel one or two (be careful not go too far to auto tint)
Lockout
When I now press the button, not only the channel I ramped to lights up but the other one starts flickering.

Video: https://imgur.com/a/1ZgQyg6

This only happens when the button is pressed. When it's released (for example when not locked out and going to moonlight) the flickering stops as soon as the button is released.
This does not happen with the tint-switching firmware (also r628), so I guess it's a firmware and not a hardware bug.

[Max Power (dermaxpower)]

Thanks for your fast patch :)

[Selene ToyKeeper (toykeeper)]

Yeah, usually Hank sends me a prototype or something so I can iron out issues like this before launch, but that didn't happen this time. So there are a few things getting fixed post-release instead. Once I got hardware to test on though, I was able to see what didn't work... and I finally got time to fix it yesterday.

Having hardware makes a big difference. :)