anduril: ramp doesn't reverse in extra modes
Bug #1802862 reported by
Selene ToyKeeper
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Flashlight Firmware Repository |
Fix Committed
|
Low
|
Unassigned | ||
Bug Description
The main output modes do auto-reversing along the ramp. Other modes, like strobes and muggle mode, still require a click-release-hold to ramp down. They should all work the same way, and they should share code to help make things more compact.
The plan is to break out the ramping/reversing code into its own generic function, and delegate input events there from the modes which use it. It'll improve usability, and it might reduce code size too.
Revision history for this message
| Selene ToyKeeper (toykeeper) wrote | #1 |
| Changed in flashlight-firmware: | |
| importance: | Medium → Low |
| status: | Confirmed → Fix Committed |
To post a comment you must log in.
Fixed in fsm branch rev 421.
It doesn't use a single central ramping logic function yet, but it does at least work. I'll probably still try refactoring it later to save space.