Firefox does not set KDE wallpaper

[Jim Massey]

Using firefox in KDE right click on an image and choose set as background, nothing happens for kde but the gconf setting is done. The same goes for changing the desktop background color. Need to change ~/.kde/share/config/kdesktoprc from setDesktopWallpaper.xul/js.

[Adam Guthrie (ispiked)]

We only implement this feature for GNOME.

[Xemanth (xemanth)]

(In reply to comment #1)
> We only implement this feature for GNOME.
>

Why only for GNOME ?

Some people prefer KDE much better Desktop Environment. Normally I use KDE and if not I'm using XFCE.

[Mike Connor (mconnor)]

Because no one has made a real effort to create a KDE version, or hooks for KDE users. There's any number of reasons, not the least of which is Konqueror is what KDE developers tend to work on.

[Massey-stlouis-shopper (massey-stlouis-shopper)]

Created attachment 257866
KDEBackground.diff

Patch adds KDE background image and color handling. Patch is against MOZILLA_1_8_BRANCH

[Jim Massey (massey)]

Using firefox in KDE right click on an image and choose set as background, nothing happens for kde but the gconf setting is done. The same goes for changing the desktop background color. Need to change ~/.kde/share/config/kdesktoprc from setDesktopWallpaper.xul/js.

[Jim Massey (massey)]

Patch allows firefox to set/change the KDE background color and wallpaper

[Freddy Martinez (freddymartinez9)]

assigning to correct package.

[Alexander Sack (asac)]

do you have more patches coming? If possible, I would like to process them in batch. Most wanted is definitly some kind of integration for preferred mailto: handler for KDE.

[Jim Massey (massey)]

I have a patch that adds a item in preferences->content that allows the user to set the default app to use for email links. Would that be good enough?

[Alexander Sack (asac)]

On Mon, Mar 12, 2007 at 06:19:02PM -0000, Jim Massey wrote:
> I have a patch that adds a item in preferences->content that allows the
> user to set the default app to use for email links. Would that be good
> enough?
>

Unfortunately not ... it would only be of worth upstream if it gives
proper kde integration e.g. what you set in kcontrol as default
mailer.

Is there a kde lib/api to access what helper is choosen? firefox uses
gconf for gnome. We could add code that is run in case kde config api
exists in pretty much the same way.

 - Alexander

[Jim Massey (massey)]

Ok. The patch attached here is it for now then.

I dont know what file in ~/.kde/share/config is used for spec'ing the default mailer app. If anyone can tell me I'll work on it. Also if there are some other KDE config items we could be picking-up and using please speak up.

We do have a kde registry reader for getting the mimetype helper apps but it is currently not compatible with a general linux build, it's for KDE targeted builds only.

[Alexander Sack (asac)]

On Mon, Mar 12, 2007 at 08:26:01PM -0000, Jim Massey wrote:
> Ok. The patch attached here is it for now then.
>
> I dont know what file in ~/.kde/share/config is used for spec'ing the
> default mailer app. If anyone can tell me I'll work on it. Also if there
> are some other KDE config items we could be picking-up and using please
> speak up.
>
> We do have a kde registry reader for getting the mimetype helper apps
> but it is currently not compatible with a general linux build, it's for
> KDE targeted builds only.
>

Is this reader a lib? then it would be fine (if its kde default). We
can try to dlopen that lib and see if it succeeds. Then query for
mimetype ... so we don't add kde dependencies to firefox.

Actually, thats the thing I initially thought about.

 - Alexander

[Jim Massey (massey)]

>Is this reader a lib?
Nope. We replace nsGomeRegistry completely and require some kde libs. The point I was trying to make is that if someone knows the kde prefs system and could clue me in I would work on rewiting it in js and then could pickup whatever we need from there.
Even in a gnome system if you use knoq there will/could be settings for helper apps in the kde registery(~/.kde/share/config I think) someplace. So theres a lot of things that could be done if I knew anything about kde prefs registry.

[Alexander Sack (asac)]

does dcop copy the image somewhere or will it just load the wallpaper load from the path in $HOME?

[Jim Massey (massey)]

The backgroun image gets saved in $home and is named 'Web Browser_wallpaper.png' and dccop is given the path to $HOME/Web Browser_wallpaper.png

I do notice that the patch attached here does not set the background color. I'll attach another patch that will also set the background color.

[Jim Massey (massey)]

I would attach an updated patch but launchpad seems to be broken, keeps telling me I did not attach anything!

[Alexander Sack (asac)]

Hi, can you please attach the latest so I can take a look and suggest improvments?

[Alexander Sack (asac)]

btw, maybe taking a look at nsGnomeRegistry replacements can give us the needed insight to do kde registry proper? Can you push code to take a look somewhere?

[Jim Massey (massey)]

Updated patch against FIREFOX_2_0_0_3_RELEASE
Patch includes correctly setting kde background color

[Jim Massey (massey)]

I dont think we need to replace nsGnomeRegistry - firefox for linux is a Gnome app. I think we can just parse the dcop files for the info we need. The problem is that there is no info or anyone(it seems - that I can find) that knows where the various settings we want to use are located.

[Alexander Sack (asac)]

On Thu, May 03, 2007 at 05:04:11PM -0000, Jim Massey wrote:
> I dont think we need to replace nsGnomeRegistry - firefox for linux is a
> Gnome app. I think we can just parse the dcop files for the info we
> need. The problem is that there is no info or anyone(it seems - that I
> can find) that knows where the various settings we want to use are
> located.
>

Maybe we can take a glance at konqueror code?

 - Alexander

[Alexander Sack (asac)]

Hi,

sorry for dropping the ball on this. For gutsy, we should definitly improve overall kde experience. So lets get started.

For this particular bug, i am a bit unhappy about the patch. It looks far too hacky to get a serious upstream consideration at some point.

Most pressing issues imo are:

 1. background filename is statically coded
 2. desktop environment detection is far from clear and doesn't really scale well. We should try to find a more general solution. Maybe we can determine DEnviornment running on current DISPLAY?
 3. To improve scalability (e.g. to reuse it for other KDE features) we should move all KDE specific backend code (like in 2.) to some XPCOM component.

More? Ideas?

[Jim Massey (massey)]

I would like to point out that freespire has a customized firefox, LBrowser, that has the patch in this bug included as well as handling of kde mimetypes/helper apps.

[Sergio Jovani (sergio-jovani)]

Please, I want this feature in my firefox, how I can?

Thanks!

[Jim Massey (massey)]

>Please, I want this feature in my firefox, how I can?

Well LBrowser has the kde integration stuff. Lbrowser is really just a customized firefox. It is available from linspire(CNR I guess).

[Freddy Martinez (freddymartinez9)]

This issue is still present in KDE 4.2 on intrepid (latest stable KDE branch as of Feb 20, 2009)

[Angel Blue01 (angel-blue-co2004)]

I can confirm this is as still present in KDE 4.2.1 and Firefox 3.06

[John Vivirito (gnomefreak)]

I'm thinking this is related to firefox-*-kde-support. QT support as a more general view.
There is or at least was an open bug report here about QT support, just not sure where it went

[John Vivirito (gnomefreak)]

This is more related to QT support as an overall statement
Changed task to 3.0
I'm not sure of progress on QT support but i thought it stalled.

[John Vivirito (gnomefreak)]

Ubuntu bug is at:
https://bugs.launchpad.net/ubuntu/+source/firefox-3.0/+bug/90851

[Mozilla (mozilla)]

That's basically a feature request instead of a bug.
Current KDE4 doesn't provide a useful way to control it easily from Firefox. The approach in the proposed patch is quite fragile I _think_.

[Jonathan Thomas (echidnaman)]

(As a note, the patch attatched here will not work with KDE4)

[Olivier Delaune (olivier-delaune)]

This bug is still valid 3 years later with KDE 4.8.5 and firefox 10.0.6 (and I guess with the latest firefox version)

[Fox (f--fox)]

it is no longer in right-click menu.

bug is fixed for good.