gtk apps' menu bars' top pixel row not clickable

[ethana2]

Trying to replace gnome-globalmenu with xmonad-- Java, Windows, and KDE applications work great..
...but I really like my GTK applications. When the window an application itself draws is flush up against the top of the screen, a click on the screen edge should be able to bring down a menu from the menu bar. One pixel row away from Fitt's Law compliance.

[Ispence (ispence)]

Created attachment 291783
Patch to give menus native vertical padding

Actually a pretty straight forward patch. I look up the vertical padding, and set it in nsNativeThemeGTK::GetWidgetPadding.

[Ispence (ispence)]

Comment on attachment 291783
Patch to give menus native vertical padding

*wonders if he's allowed to request approval1.9*

[Beltzner (beltzner)]

Comment on attachment 291783
Patch to give menus native vertical padding

a=drivers for after the Firefox 3 Beta 2 freeze

[Dao (dao)]

Comment on attachment 291783
Patch to give menus native vertical padding

>Index: widget/src/gtk2/nsNativeThemeGTK.cpp

>+ if (aWidgetType == NS_THEME_MENUPOPUP) {
>+ gint vertical_padding;
>+ moz_gtk_get_menu_popup_vertical_padding(&vertical_padding);
>+
>+ aResult->SizeTo(0, vertical_padding, 0, vertical_padding);
>+ return PR_TRUE;
>+ }

The indention is wrong. Should be two spaces in this file.

[Ispence (ispence)]

Created attachment 292319
Updates the indentation

The same the the last patch, but with reduced tabs.

Do I need to re-request approval?

[Reed Loden (reed)]

(In reply to comment #5)
> Do I need to re-request approval?

Nope. Once the tree reopens, I'll commit the change.

[Reed Loden (reed)]

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v <-- gtk2drawing.c
new revision: 1.49; previous revision: 1.48
done
Checking in widget/src/gtk2/gtkdrawing.h;
/cvsroot/mozilla/widget/src/gtk2/gtkdrawing.h,v <-- gtkdrawing.h
new revision: 1.42; previous revision: 1.41
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v <-- nsNativeThemeGTK.cpp
new revision: 1.121; previous revision: 1.120
done

[Ispence (ispence)]

This should probably be backed out until I can figure out how to determine how to be sure it is a dropdown from the menubar/toolbar (or a submenu of one).

This padding, while it is the correct thing to do, it being exposed as a problem with the fix of bugs like bug 398242

[Reed Loden (reed)]

Backed out.

[Ispence (ispence)]

*** Bug 412084 has been marked as a duplicate of this bug. ***

[Bugs-mutantmonkey (bugs-mutantmonkey)]

Since bug 398242 is obsolete, can someone take a look at this again? This is very annoying for me.

[ethana2 (ethana2)]

Trying to replace gnome-globalmenu with xmonad, Java, Windows, and KDE applications work great..
...but I really like my GTK applications. When the window an application itself draws is flush up against the top of the screen, a click on the screen edge should be able to bring down a menu from the menu bar. One pixel row away from Fitt's Law compliance.

[ethana2 (ethana2)]

DarkRoom theme works properly in this regard.

[ethana2 (ethana2)]

Firefox doesn't honor theme settings, so even with a well behaved theme it doesn't work properly-- nor does it work properly with gnome-globalmenu. ..Continuing to use Empathy and Midori as workaround.

[ethana2 (ethana2)]

s/Empathy/Epiphany.

[Fabio Marconi (fabiomarconi)]

Thank you for taking the time to report this bug and helping to make Ubuntu better.
Is this bug reproducible with the latest Lucid packages ?
Tanks in advance.

[ethana2 (ethana2)]

This bug is obsolete due to the new Ubuntu Menu Bar.

On Aug 1, 2010 2:15 PM, "Fabio Marconi" <email address hidden> wrote:

Thank you for taking the time to report this bug and helping to make Ubuntu
better.
Is this bug reproducible with the latest Lucid packages ?
Tanks in advance.

** Changed in: ubuntu
      Status: New => Incomplete

--
gtk apps' menu bars' top pixel row not clickable
https://bugs.launchpad.net/bugs/393997
You rec...

[tsg1zzn (tsg1zzn)]

*** Bug 393688 has been marked as a duplicate of this bug. ***

[Release-mgmt-account-bot (release-mgmt-account-bot)]

The bug assignee didn't login in Bugzilla in the last 7 months.
:stransky, could you have a look please?
For more information, please visit [auto_nag documentation](https://wiki.mozilla.org/Release_Management/autonag#assignee_no_login.py).