[snap] Unmaximized but not unfullscreened

[vasdi]

Ubuntu 21.10
Firefox 99.0.1-1 from snap

With title bar hidden:
 maximize Firefox window
 set it full-screen
 move cursor to the upper edge of the screen
 double-click the bar

The window ends up in unexpected state

[Paul White (paulw2u)]

Thank you for taking the time to report this bug and help make Ubuntu better.

The Firefox snap is now provided by Mozilla and not by Canonical or Ubuntu developers, and they may not be aware of this issue. If this you are still experiencing this problem then please contact them via https://support.mozilla.org/kb/file-bug-report-or-feature-request-mozilla and link the bug report here so it can be further tracked. Thank you!

[vasdi (vasdi)]

Created attachment 9279747
firefoxbug.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

Ubuntu 21.10
Gnome 42.1, X11
Firefox from snap, reproducible in Nightly build 20220604092742

With title bar hidden:
   maximize Firefox window (by double-click on top bar)
   set it full-screen (by pressing F11 key)
   move cursor to the upper edge of the screen
   double-click the bar

Actual results:

The window ends up in unexpected state. It behaves as fullscreen window but it's not one.

Expected results:

I expect window to stay maximized.

[Release-mgmt-account-bot (release-mgmt-account-bot)]

The [Bugbug](https://github.com/mozilla/bugbug/) bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

[Emilio (emiliocobos)]

Created attachment 9279753
Bug 1772693 - Fix transition from fullscreen to maximized. r=stransky

We don't call MakeFullScreen(false), causing weirdness. This is needed even
with the next patch because otherwise other things like grabbing the tabbar
cause the same kind of weirdness.

[Emilio (emiliocobos)]

Created attachment 9279754
Bug 1772693 - Don't transition from fullscreen -> maximized on double-click. r=stransky

It's probably unexpected (even though after the patch above it behaves
properly).

Depends on D148340

[Phab-bot (phab-bot)]

Comment on attachment 9279753
Bug 1772693 - Fix transition from fullscreen to maximized. r=stransky

Revision D148340 was moved to bug 1773118. Setting attachment 9279753 to obsolete.

[Pulsebot (pulsebot)]

Pushed by <email address hidden>:
https://hg.mozilla.org/mozilla-central/rev/844584297b2c
Don't transition from fullscreen -> maximized on double-click. r=stransky

[Nfay (nfay)]

https://hg.mozilla.org/mozilla-central/rev/844584297b2c

[Oana-ardelean (oana-ardelean)]

I managed to reproduce this issue on a 2022-06-04 Nightly build on Ubuntu 22.04 using the steps from the Description. Verified as fixed on Firefox 103.0b9(build ID: 20220714185732), Nightly 104.0a1(build ID: 20220717190235) and Nightly 104.0a1 Snap build(build ID: 20220718020349) on Ubuntu 22.04.