Comment 44 for bug 1194841

Revision history for this message
In , Patrick McManus (mcmanus-ducksong) wrote :

Comment on attachment 735214
patch 0

[Approval Request Comment] (firefox 22 aurora)
Bug caused by (feature/regressing bug #): 824341

User impact if declined: Linux desktop users who once had configured a manual proxy but are no longer using that configuration may still use the old configuration (probably pointing at a non working proxy) depending on the details of their new proxy settings. (e.g. if their new setting is "use system settings" and the system settings returns an err).

Testing completed (on m-c, etc.): verified on m-c

Risk to taking this patch (and alternatives if risky):

the patch for this is short and low risk. Its downside is that it touches code that runs on all platforms and all transactions in order to make a fix for a very small population.

an alternative would be to backout 824341 (a linux specific change) from aurora-22. The bug fixed by this patch would remain latent, but without 824341 we don't have any reports of it affecting anything.

String or IDL/UUID changes made by this patch: none.