[needs-packaging] htmlvalidator

[Pander]

name: firefox-validator

url: https://addons.mozilla.org/en-US/firefox/addon/249

description: HTML Validator is a Mozilla extension that adds HTML validation inside Firefox and Mozilla. The number of errors of a HTML page is seen on the form of an icon in the status bar when browsing.

comments: Depends on firefox, the linkwidgets package is an xpi file

[Justin M. Wray (wray-justin)]

Why would we want to package this "package" and place it in the repositories, when you simply goto the site from Firefox, and install the file?

Thanks,
Justin M. Wray

[Justin M. Wray (wray-justin)]

I should comment, this is only a question and in no form an "official" response to such a request. As Ubuntu has plenty of Firefox addons within the repositories. I just wanted to get your perspective on how this is helpful?

Firefox does the following already:
 * Easy and secure install of addons
 * Updates and compatibility management

Just my thoughts, I confirmed the bug for you...

Thanks,
Justin M. Wray

[Pander (pander)]

Hi Justin,

Thanks for having confirmed this bug. Advantage of packaging Firefox addons as Ubuntu packages is that you can install them (and manage upgrades) for an entire system and for all users at once. Also when users are not allowed to install addons this is a better way to manage them centrally for a system.

This actualy goes for all addons, plugins, etc. which you can manage by the application itself (like firefox, thunderbird, amarok) or via apt-get and friends if you would like to do that system wide.

Thanks,

Pander

[Andrea Chiavazza (andrea-c7a)]

The xpi file from the official site (0.846 at present) is linked with obsolete libraries.
On Hardy beta it requires me to have installed for this purpose alone the 2 packages
libstdc++5
gcc-3.3-base
A packaged version could be compiled with libstdc++6 and remove these dependencies.

[revford (revford)]

The xpi from the developer's site required me to install libstdc++5 and libxul-dev to get it working.

[Brian Murray (brian-murray)]

It'd be helpful if you were to do some research into this extension and add information about its license etcetera to the wiki page at https://wiki.ubuntu.com/MozillaTeam/Firefox3Extensions. It should belong in either the "needs maintainter" table or the "missing details" if someone needs to do research on it. Thanks in advance!

[John Vivirito (gnomefreak)]

Brian Murray wrote:
> It'd be helpful if you were to do some research into this extension and
> add information about its license etcetera to the wiki page at
> https://wiki.ubuntu.com/MozillaTeam/Firefox3Extensions. It should belong
> in either the "needs maintainter" table or the "missing details" if
> someone needs to do research on it. Thanks in advance!
>
> ** Also affects: firefox-extensions
> Importance: Undecided
> Status: New
>
Let me know if you need help with it. I have a little freetime i can do
the research on it and ill look into packaging it if you cant.

--
Sincerely Yours,
    John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246

[John Vivirito (gnomefreak)]

I will look into the depends while im at it today. Some extensions we wont and/or cant maintain, this is why we have https://wiki.ubuntu.com/MozillaTeam/Firefox3Extensions so people can see why it cant be or even what progress is.

[John Vivirito (gnomefreak)]

Pander can you please add the info needed on https://wiki.ubuntu.com/MozillaTeam/Firefox3Extensions before i look at it just incase something else doesnt meet requirements

[Benjamin Drung (bdrung)]

htmlvalidator depends on tidy (written in C) and opensp (written in C++) and therefore it is not platform independent. So you need a xpi file for every platform. Therefore it is very useful to have an Ubuntu package.

The original source package has to be included into the Firefox build process. The xpi file is generated with some scripts. I am working on the htmlvalidator package to make it easier to compile. It now uses autotools and only needs the development package of Firefox. You can get the source from the SourceForge.net SVN repository. You can checkout it with "svn co https://htmlvalidator.svn.sourceforge.net/svnroot/htmlvalidator/trunk htmlvalidator". I have uploaded the current version to my PPA: https://launchpad.net/~bdrung/+archive

There is a lot to do to get this package ready for universe and I am thankful for help:

* A AUTHORS and LICENCE file is missing.
* configure.ac and all the Makefile.am could be cleaned and make them more portable (maybe use of libtool).
* split the package into htmlvalidator and htmlvalidator-data

[Alexander Sack (asac)]

On Fri, Jun 27, 2008 at 03:28:52PM -0000, Benjamin Drung wrote:
> htmlvalidator depends on tidy (written in C) and opensp (written in C++)
> and therefore it is not platform independent. So you need a xpi file for
> every platform. Therefore it is very useful to have an Ubuntu package.
>

Yes, I agree. native extensions have high-prio as we can make them
available on all platforms supported.

> The original source package has to be included into the Firefox build
> process. The xpi file is generated with some scripts. I am working on
> the htmlvalidator package to make it easier to compile. It now uses
> autotools and only needs the development package of Firefox. You can get
> the source from the SourceForge.net SVN repository. You can checkout it
> with "svn co
> https://htmlvalidator.svn.sourceforge.net/svnroot/htmlvalidator/trunk
> htmlvalidator". I have uploaded the current version to my PPA:
> https://launchpad.net/~bdrung/+archive

We dont want the complete firefox source in the source package. so we
need to do some work to clean this up.

I guess that this extension requires the mozilla buildsystem (which is
usually the reason why extensions require a full ffox source tree).

We ship a build-system in latest intrepid bzr branch for xulrunner and
probably should look into making that usable for extensions as well
(it was created to support xulapps).

>
> There is a lot to do to get this package ready for universe and I am
> thankful for help:
>
> * A AUTHORS and LICENCE file is missing.
> * configure.ac and all the Makefile.am could be cleaned and make them more portable (maybe use of libtool).
> * split the package into htmlvalidator and htmlvalidator-data
>

 affects firefox-extensions
 status confirmed

 - Alexander

[John Vivirito (gnomefreak)]

Benjamin Drung wrote:
> htmlvalidator depends on tidy (written in C) and opensp (written in C++)
> and therefore it is not platform independent. So you need a xpi file for
> every platform. Therefore it is very useful to have an Ubuntu package.
>
> The original source package has to be included into the Firefox build
> process. The xpi file is generated with some scripts. I am working on
> the htmlvalidator package to make it easier to compile. It now uses
> autotools and only needs the development package of Firefox. You can get
> the source from the SourceForge.net SVN repository. You can checkout it
> with "svn co
> https://htmlvalidator.svn.sourceforge.net/svnroot/htmlvalidator/trunk
> htmlvalidator". I have uploaded the current version to my PPA:
> https://launchpad.net/~bdrung/+archive
>
> There is a lot to do to get this package ready for universe and I am
> thankful for help:
>
> * A AUTHORS and LICENCE file is missing.
> * configure.ac and all the Makefile.am could be cleaned and make them more portable (maybe use of libtool).
> * split the package into htmlvalidator and htmlvalidator-data
>
>
> ** Changed in: firefox-extensions
> Status: Incomplete => New
>
Thank you for adding it to
https://wiki.ubuntu.com/MozillaTeam/Firefox3Extensions
this is something we will throw around with eachother in
#ubuntu-mozillateam and/or the mailing list. Personally i feel
uncomfortable addding this to the firefox build but i will see what the
outcome is during the talk.

--
Sincerely Yours,
    John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246

[John Vivirito (gnomefreak)]

Alexander Sack wrote:
> On Fri, Jun 27, 2008 at 03:28:52PM -0000, Benjamin Drung wrote:
>> htmlvalidator depends on tidy (written in C) and opensp (written in C++)
>> and therefore it is not platform independent. So you need a xpi file for
>> every platform. Therefore it is very useful to have an Ubuntu package.
>>
>
> Yes, I agree. native extensions have high-prio as we can make them
> available on all platforms supported.
>
>
>> The original source package has to be included into the Firefox build
>> process. The xpi file is generated with some scripts. I am working on
>> the htmlvalidator package to make it easier to compile. It now uses
>> autotools and only needs the development package of Firefox. You can get
>> the source from the SourceForge.net SVN repository. You can checkout it
>> with "svn co
>> https://htmlvalidator.svn.sourceforge.net/svnroot/htmlvalidator/trunk
>> htmlvalidator". I have uploaded the current version to my PPA:
>> https://launchpad.net/~bdrung/+archive
>
> We dont want the complete firefox source in the source package. so we
> need to do some work to clean this up.
>
> I guess that this extension requires the mozilla buildsystem (which is
> usually the reason why extensions require a full ffox source tree).
>
> We ship a build-system in latest intrepid bzr branch for xulrunner and
> probably should look into making that usable for extensions as well
> (it was created to support xulapps).
>
>> There is a lot to do to get this package ready for universe and I am
>> thankful for help:
>>
>> * A AUTHORS and LICENCE file is missing.
>> * configure.ac and all the Makefile.am could be cleaned and make them more portable (maybe use of libtool).
>> * split the package into htmlvalidator and htmlvalidator-data
>>
>
> affects firefox-extensions
> status confirmed
>
>
> - Alexander
>
>
> ** Changed in: firefox-extensions
> Status: New => Confirmed
>
Ignore my last email/post as i didnt see Alexanders post.

--
Sincerely Yours,
    John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246

[John Vivirito (gnomefreak)]

marked to incomplete because we dont have all info needed. Before we can add this extension to repos we need for it to have a license. someone needs to email
<Marc Gueury> <email address hidden>
and ask him to please add a license file to the package, it needs to be included with source.

[John Vivirito (gnomefreak)]

If someone emails him please post here that you did and are waiting for reply or have a reply and let us know what he says please.

[Pander (pander)]

I'll contact him and post the result here.

[John Vivirito (gnomefreak)]

Pander wrote:
> I'll contact him and post the result here.
>
Thanks

--
Sincerely Yours,
    John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246

[John Vivirito (gnomefreak)]

removing ubuntu task as its not needed.

[Benjamin Drung (bdrung)]

@Alexander Sack & John Vivirito

Maybe I explained it bad. The modified source package does _not_ need the build system from Firefox to build the extension. It only needs the header files from Firefox. It uses autotools for detection. You can grab the source file on Sourceforge: http://sourceforge.net/project/showfiles.php?group_id=134222
tidy_0852_source.zip is the original source package by Marc Gueury
htmlvalidator-0.8.5.2+svn45.tar.gz is the source package modified by me. You can grab the debian package based on this source file from my PPA.

[Alexander Sack (asac)]

On Mon, Jun 30, 2008 at 12:23:19AM -0000, Benjamin Drung wrote:
> @Alexander Sack & John Vivirito
>
> Maybe I explained it bad. The modified source package does _not_ need the build system from Firefox to build the extension. It only needs the header files from Firefox. It uses autotools for detection. You can grab the source file on Sourceforge: http://sourceforge.net/project/showfiles.php?group_id=134222
> tidy_0852_source.zip is the original source package by Marc Gueury
> htmlvalidator-0.8.5.2+svn45.tar.gz is the source package modified by me. You can grab the debian package based on this source file from my PPA.
>

we ship the headers with xulrunner-1.9-dev package (aka xulrunner
sdk). Anyone can give it a shot?

 - Alexander

[Benjamin Drung (bdrung)]

Build-Depends: build-essential, cdbs, debhelper (>= 5), libosp-dev, pkg-config, xulrunner-1.9-dev, zip

[Alexander Sack (asac)]

On Mon, Jun 30, 2008 at 04:41:09PM -0000, Benjamin Drung wrote:
> Build-Depends: build-essential, cdbs, debhelper (>= 5), libosp-dev, pkg-
> config, xulrunner-1.9-dev, zip
>

build essential is not needed. as build-depends. Not sure about
debhelper.

 - Alexander

[Benjamin Drung (bdrung)]

Here is an updated version of the proposed package. Can someone review the package? Except of the missing license the package should be alright. I am in contact with the upstream author. He is thinking about the license and will decide soon. Then I will update the package and create the required bazaar branches.

I have uploaded the package for hardy into my PPA: https://launchpad.net/~bdrung/+archive

[Alexander Sack (asac)]

can you do this as a bzr branch using mozilla-devscript xpi.mk and at best med-xpi-unpack to use our standard source format (when you package from .xpis)

[Benjamin Drung (bdrung)]

I do not package it from a .xpi, because this package is platform depending.

[Alexander Sack (asac)]

1. Please fix the copyright.

2. please dont start with comments in the code ;) ...

--- htmlvalidator-0.8.5.3+svn48.orig/debian/rules
+++ htmlvalidator-0.8.5.3+svn48/debian/rules
@@ -0,0 +1,7 @@
+#!/usr/bin/make -f
+
+include /usr/share/cdbs/1/rules/debhelper.mk
+#include /usr/share/cdbs/1/rules/simple-patchsys.mk
^^ like here -> just remove that line

(3. would you mind to do bzr branch out of this that is hosted in the firefox-extensions project)

4. please make the package lintian clean (if its not yet).

[Benjamin Drung (bdrung)]

All done: License questions is solved (GPLv3), simple-patchsys.mk removed and made it lintian clean.
upstream branch: lp:~bdrung/firefox-extensions/htmlvalidator.upstream
ubuntu branch: lp:~bdrung/firefox-extensions/htmlvalidator.ubuntu
You can find this package for hardy in my PPA: https://launchpad.net/~bdrung/+archive

[Tristan Hill (stan)]

Are any special steps required to use the ppa version? I've installed it from the ppa (on jaunty) and restarted firefox but don't see the extension listed in the add-ons. I notice other packaged extensions create symlinks in /usr/lib/firefox-addons/extensions and wondered if this was missing.

[Benjamin Drung (bdrung)]

The symlinks were not created due to a missing build dependency. I have fixed it now in my PPA.

[Aditya V (kroq-gar78)]

Just a note, the package hasn't actually been released by Debian (as implied by the previous, misleading message). The RFP bug has only been closed because there were 18 months of inactivity.

[papukaija (papukaija)]

The number of extensions in the archive is being reduced. The list of supported extensions in the archive is aimed to kept in an absolute minimum.

See the spec here: https://wiki.ubuntu.com/DesktopTeam/Specs/Lucid/FirefoxNewSupportModel/ Therefore, this bug is closed.

[Pander (pander)]

kroq-gar78, for Debian, set it to won't fix or invalid? Then it wont list itself here that action can still be expected.