Problem with videos without audio track

Bug #819391 reported by Beat Trachsler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firefogg
Fix Released
Undecided
Unassigned

Bug Description

If I try to encode a video file without audio track to the webm container format, the encoding doesn't start and the following error is reported by the error console:

uncaught exception: [Exception... "'[JavaScript Error: "info.audio[0] is undefined" {file: "resource://firefogg/encoder.jsm" line: 320}]' when calling method: [nsIFirefogg::encode]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: http://firefogg.org/make/# :: <TOP_LEVEL> :: line 165" data: yes]

I have found the reason(s) for this problem and could fix it by the following lines within the file "encoder.jsm":
l 319: if(info.audio && info.audio[0]) {
l 320: var sourceSamplerate = info.audio[0].samplerate;
...
l 323: delete options.samplerate;
The most important change is to add && info.audio[0] at line 319. With this it should work.

Regards,

Beat

Revision history for this message
Beat Trachsler (beat-trachsler) wrote :
Revision history for this message
j^ (j) wrote :

thanks, will be fixed in next release

Changed in firefogg:
status: New → Fix Committed
j^ (j)
Changed in firefogg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.