setup assumes that sphinx-build is present in /usr/bin which is not always the case
Bug #847044 reported by
Manish Sinha (मनीष सिन्हा)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
FileStore |
Fix Released
|
High
|
Manish Sinha (मनीष सिन्हा) | ||
Microfiber |
Fix Released
|
High
|
Manish Sinha (मनीष सिन्हा) |
Bug Description
In build-with_docs method in setup.py it is assumed that sphinx-build will always be present in /usr/bin i.e. $prefix is always /usr/
In case sphinx is installed locally it will go in /usr/local unless --prefix=/usr/ is explicitly passed when building sphinx.
In other situation sphinx can also be present in /opt
It is better to scan where sphinx is present by getting the PATH environment varible, spitting it by ; and then appending sphinx-build and checking if it exists. Do note that /usr/local/bin has higher priority than /usr/bin/
Related branches
lp:~manishsinha/microfiber/fix-hardcoded-sphinx-build-in-usrbin
- Jason Gerard DeRose: Approve
-
Diff: 24 lines (+10/-2)1 file modifiedsetup.py (+10/-2)
lp:~manishsinha/filestore/fix-sphinx-hardcoding-in-usrbin
- Jason Gerard DeRose: Approve
-
Diff: 32 lines (+11/-2)1 file modifiedsetup.py (+11/-2)
Changed in filestore: | |
status: | New → In Progress |
Changed in microfiber: | |
status: | New → In Progress |
Changed in filestore: | |
assignee: | nobody → Manish Sinha (मनीष सिन्हा) (manishsinha) |
Changed in microfiber: | |
assignee: | nobody → Manish Sinha (मनीष सिन्हा) (manishsinha) |
Changed in filestore: | |
importance: | Undecided → High |
Changed in microfiber: | |
importance: | Undecided → High |
Changed in filestore: | |
status: | In Progress → Fix Committed |
Changed in microfiber: | |
status: | In Progress → Fix Committed |
Changed in filestore: | |
milestone: | none → 11.09 |
Changed in microfiber: | |
milestone: | none → 11.09 |
Changed in microfiber: | |
status: | Fix Committed → Fix Released |
Changed in filestore: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.