--info flag returns invalid JSON

Bug #1265233 reported by Mason McLead
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ffmpeg2theora
Fix Committed
Undecided
Unassigned

Bug Description

When getting the metadata about the files the json_add_key_value method creates JSON values with invalid characters.

This causes the returned JSON to be invalid.

See this branch for updated code with a fix

https://github.com/mmclead/ffmpeg2theora/tree/strip-extra-character-in-json

Here is a pull request to my own repository

https://github.com/mmclead/ffmpeg2theora/pull/1

Tags: info json tag
Revision history for this message
Nick Messick (nmessick) wrote :

Here is an example of some invalid JSON output from ffmpeg2theora: https://gist.github.com/messick/8202020

the key "handler_name" has a value with a '\f' character, which is illegal according to defintition of "char" on json.org. The following lists should be escaped:

\"
\\
\/
\b
\f
\n
\r
\t
\u four-hex-digits

Revision history for this message
j^ (j) wrote :
Changed in ffmpeg2theora:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.