Comment 48 for bug 1729674

> On 20 Nov 2017, at 11:47 PM, Dave Chiluk <email address hidden> wrote:
>
> I reviewed your patch, and it appears as if it only turns off receive
> checksumming. The internets are saying that transmit needs to be turned off
> as well. Have you checked to see if transmit is affected as well?

TX is not affected under my simple NFS testing.

>
> I will try to do some transmit tests. I'll also "test" your kernel when I
> get a chance, but by the looks of the patch there shouldn't be too much to
> test as it simply turns off RX checksuming which is already a known good
> solution.

Yea, just want to make sure USB/PCI ids are the same for both TB15 and TB16.
The TB15 at my hand is not even the mass production one.

>
> On Mon, Nov 20, 2017 at 2:06 AM, Kai-Heng Feng <email address hidden>
> wrote:
>
>> Dave,
>>
>> Please try this kernel,
>> http://people.canonical.com/~khfeng/lp1729674/
>>
>> The temporary workaround is what we can get before chip vendors solve
>> the issue.
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1729674
>>
>> Title:
>> TB16 dock ethernet corrupts data with hw checksum silently failing
>>
>> Status in Dell Sputnik:
>> Triaged
>> Status in linux package in Ubuntu:
>> In Progress
>> Status in linux package in Fedora:
>> Confirmed
>>
>> Bug description:
>> It looks like TCP rx and tx checksum offloading is broken on the TB16
>> dock's ethernet adapter. For example downloading a large file such as the
>> Ubuntu ISO, and then running an md5sum on it yields the incorrect md5sum.
>> This is because
>> rx-checksumming: on
>> tx-checksumming: on
>> and both set to on by default.
>>
>> Running sudo ethtool -K <TB16 eth device> tx off rx off, allows the
>> download to complete correctly. This is very bad since this can cause
>> very bad untrustworthy behavior.
>>
>> This was conducted using an Dell Precision 5520 on Ubuntu 16.04+linux-
>> generic-hwe-16.04-edge.
>>
>> Thank you
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/dell-sputnik/+bug/1729674/+subscriptions
>>
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1729674
>
> Title:
> TB16 dock ethernet corrupts data with hw checksum silently failing
>
> Status in Dell Sputnik:
> Triaged
> Status in linux package in Ubuntu:
> In Progress
> Status in linux package in Fedora:
> Confirmed
>
> Bug description:
> It looks like TCP rx and tx checksum offloading is broken on the TB16 dock's ethernet adapter. For example downloading a large file such as the Ubuntu ISO, and then running an md5sum on it yields the incorrect md5sum. This is because
> rx-checksumming: on
> tx-checksumming: on
> and both set to on by default.
>
> Running sudo ethtool -K <TB16 eth device> tx off rx off, allows the
> download to complete correctly. This is very bad since this can cause
> very bad untrustworthy behavior.
>
> This was conducted using an Dell Precision 5520 on Ubuntu 16.04+linux-
> generic-hwe-16.04-edge.
>
> Thank you
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/dell-sputnik/+bug/1729674/+subscriptions