Facebook Friends Graph fails when friends have a dash in their name

Bug #522487 reported by Julien Ropé
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Facebook Friends Graph
Fix Released
Kamran Riaz Khan

Bug Description

 I have friends that have a composed firstname (like : "Jean-Marie"). The dash causes an error in pydot when trying to draw the graph.

 I could solve it by modifying fbfriendsgraph.py in ConnectionsParser.run()
 I replaced :

edges.append((dictnames[j[u'uid1']], dictnames[j[u'uid2']]))

 by :

name1 = '"%s"' % dictnames[j[u'uid1']]
name2 = '"%s"' % dictnames[j[u'uid2']]
edges.append((name1, name2))

This has solve the problem and allowed me to see the resulting graph.

I don't know if this could cause other issues elsewhere, but at least it worked for me...


Revision history for this message
Kamran Riaz Khan (inspirated) wrote :

Thanks for the fix, LittleJawa. Committed in revision 3.

Changed in fbfriendsgraph:
status: New → Fix Committed
Changed in fbfriendsgraph:
importance: Undecided → Medium
assignee: nobody → Kamran Riaz Khan (inspirated)
Changed in fbfriendsgraph:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.