PATCH: Select audio output device without Custom Sink

Bug #871544 reported by Dustin Spicuzza on 2011-10-10
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
Dustin Spicuzza

Bug Description

Currently, the only way to use an alternate audio device that is not the 'default' is to provide a custom audio sink argument with the correct parameters, which is highly inconvenient for the typical user to do. This patch provides a setting and a preferences object that enumerates available devices for those types of sinks that support it, and displays those options to the user.

This patch is against trunk r3893. Tested on Ubuntu 11.10.

Related branches

Johannes Sasongko (sjohannes) wrote :

Thanks, it's something I've been interested in as well. Testing the patch as we speak.

Changed in exaile:
milestone: none → 0.3.3.0
status: New → In Progress
assignee: nobody → Dustin Spicuzza (dustin-virtualroadside)
Johannes Sasongko (sjohannes) wrote :

Committed, with style changes in a separate commit. Also changed

  name += ' ' + d['pipeargs']

which I think is a typo to

  pipe += ' ' + d['pipeargs']

Changed in exaile:
status: In Progress → Fix Committed
Stefan Reich (at-1tef3n-n1) wrote :

Hmm.. Will this go into the next release then (if yes, which one)?

Will it be there if I build from Bazaar?

I propose an additional patch for this. Instead of manually specifying which devices support property probes, we just try to autodetect whether the sink has that capability. This allows us to support device probing as devices allow it. This patch is on top of your commit to trunk.

Also has been pushed to my dj_improvements branch

Additional improvement to patch.

Changed in exaile:
status: Fix Committed → In Progress
Mathias Brodala (mathbr) on 2012-01-18
Changed in exaile:
importance: Undecided → Medium
status: In Progress → Fix Committed
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers