cd plugin bugs with the new playlist class and formatter

[Rocco Aliberti]

I tried to patch them, but i'm not convinced about a couple of points, e.g.
(watching the attachment)

plugins/cd/__init__.py

@@ -174,7 +174,7 @@

- tr = self.ordered_tracks[i]
+ tr = self[i]

There's a similar case in xlgui/panel/flatplaylist.py, there is needed the entire list of tracks.

It would be better xl.playlist methods that return the list of the tracks and the single track, i think.

[Rocco Aliberti (eri.trabiccolo)]

I just noticed that Playlist.__getitem__ was rewritten and returns just a track object, then that aspect is not a problem. Sorry

[Mathias Brodala (mathbr)]

What’s the formatter issue you mention in the title?

[Rocco Aliberti (eri.trabiccolo)]

I meant the formatter.TrackFormatter constructor.

[Johannes Sasongko (sjohannes)]

I assume this is on trunk? Filing there so we don't forget.

[Rocco Aliberti (eri.trabiccolo)]

Yes it's on trunk, Sorry for inaccuracies

[Rocco Aliberti (eri.trabiccolo)]

I saw that in last rev(3909) mathbr, made some changes to cd rom plugin, but more are needed. The patches I uploaded months ago may not be the best way to fix those bugs but at least it can serve as a starting point to understand where the bugs occur.

[Rocco Aliberti (eri.trabiccolo)]

Patch against rev3920.

[Dustin Spicuzza (dustin-virtualroadside)]

I took your patch and modified it a bit. I didn't retain the menu modifications since the whole flatplaylist/devices/etc should be redone anyways at some point, no sense confusing the code with a mix of old and new stuff.

For some reason CDDB doesn't seem to be working for me, but I'm not sure if it's exaile's fault or not.

Anyways, pushed in revision 3970

[Rocco Aliberti (eri.trabiccolo)]

Of course, was an old patch and maybe even then wasn't "perfect" :D
Anyway here your commit works (CDBB works for me), except for the menù item "Properties" of the cd-track. Signal connection missing? Is it really useful for a cd track?

Thanks.

[Dustin Spicuzza (dustin-virtualroadside)]

Yeah, the signal wasn't connected, and it was that way in Exaile 0.3.2 so I elected to leave it that way for now. It's not actually useful for a CD track the way properties are currently implemented. It would be nice if one could actually name the tracks correctly if CDDB didn't work, but I think that will have to be done in 0.3.3.1 or past that.

[Rocco Aliberti (eri.trabiccolo)]

Yeah i see. I was thinking that menu is about flatplaylist (?) so maybe "Properties" may be useful in other contexts, but I don't know what else extends that class.