Lyrics plugin exception causes all other lyrics plugins to fail

Bug #704020 reported by cousteau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
New
Undecided
Unassigned

Bug Description

This is actually a two-parts bug report (maybe I should split it into 2 separate bug reports, but I think the second one is trivial enough):

1) If a lyrics search plugin fails, raising an exception other than LyricsNotFoundException, the global Lyrics Viewer plugin stops checking with other lyrics search plugin.

2) The current LyricWiki lyrics plugin fails if the song title or artist has non-ASCII characters. These Unicode non-ASCII characters cause urllib.quote() to raise a KeyError (which doesn't happen when using a plain string). This can be fixed in /usr/share/exaile/plugins/lyricwiki/__init__.py, adding .encode() to lines 49-50 like:
        artist = urllib.quote(artist.encode('utf-8').replace(' ','_'))
        title = urllib.quote(title.encode('utf-8').replace(' ','_'))
(or maybe 'latin-1' instead of 'utf-8', or whatever does LyricWiki use; raise LyricsNotFoundException if non-ASCII is not supported at all).

Ubuntu 10.10 64b, Exaile 0.3.2.0-0ubuntu3 from Ubuntu universe repositories

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.