SyntaxError in _base.py and playback.py

[David Wagner]

The bzr head (r3510) introduces a compilation error not present in the prior version (r3509). r3509 compiles cleanly on my machine, but attempting to compile r3510 fails with the following errors:

$ make clean; make
find . -name "*.~[0-9]~" -exec rm -f {} \;
find . -name "*.py[co]" -exec rm -f {} \;
find po/* -depth -type d -exec rm -r {} \;
rm -f exaile.1.gz
make -C plugins clean
make[1]: Entering directory `/home/daw/e/exaile03/plugins'
find . -name "*.py[co]" -exec rm -f {} \;
make[1]: Leaving directory `/home/daw/e/exaile03/plugins'
python -m compileall -q xl xlgui
Compiling xlgui/actions/_base.py ...
SyntaxError: ('invalid syntax', ('xlgui/actions/_base.py', 130, 29, ' gobject.TYPE_INT,\n'))

Compiling xlgui/actions/playback.py ...
SyntaxError: ('invalid syntax', ('xlgui/actions/playback.py', 90, 73, " for ev in ['player_end', 'track_start', 'toggle_pause', 'error']\n"))

make: *** [compile] Error 1

I'm on Fedora 13 x86_64.

Eyeballing line 132 of xlgui/actions/_base.py, is it missing a comma after the end of that line? Eyeballing line 90 of xlgui/actions/playback.py, is it missing a colon (:) at the end of the line?

[Mathias Brodala (mathbr)]

Fixed with r3511, thanks.

[David Wagner (daw-bugzilla)]

It's not fully fixed for me. As of r3520, I get this:

$ make clean; make
find . -name "*.~[0-9]~" -exec rm -f {} \;
find . -name "*.py[co]" -exec rm -f {} \;
find po/* -depth -type d -exec rm -r {} \;
rm -f exaile.1.gz
make -C plugins clean
make[1]: Entering directory `/home/daw/e/exaile03/plugins'
find . -name "*.py[co]" -exec rm -f {} \;
make[1]: Leaving directory `/home/daw/e/exaile03/plugins'
python -m compileall -q xl xlgui
Compiling xlgui/actions/_base.py ...
SyntaxError: ('invalid syntax', ('xlgui/actions/_base.py', 130, 29, ' gobject.TYPE_INT,\n'))

make: *** [compile] Error 1

Looking at it more closely, I suspect the syntax error is in this line:

        'active-choice': {

I suspect that should be:

        'active-choice': (

In other words, open-parenthesis instead of open-curly-brace.

[reacocard (reacocard)]

fixed again r3521