'Replace playlist' action

[Adam Olsen]

Exaile has only the option to add files to the current playlist. After listening to one CD, I'd like to be able to select another one and right-click->replace playlist...

Cheers!

-H-

This ticket was migrated from the old trac: re #362

[Adam Olsen (arolsen)]

This ticket is a duplicate

[Sean Hodges (seanhodges)]

I'd like to see this action included as well, wheres the original ticket if this is a dupe?

[Sean Hodges (seanhodges)]

Sorry I'm not able to find the original ticket, attached is a fix to add a "Replace Current" item to the collection context menu.

I'll post this elsewhere if required.

[Sean Hodges (seanhodges)]

Cannot find the dupe, so re-opening the ticket for now

[Adam Olsen (arolsen)]

I like this patch, but I don't understand why it's assuming that playback should restart on the new playlist?

[Steve Dodier-Lazaro (sidi)]

In Exaile 0.3.x, tracks/albums can only be appended to current from the collection, while they can be appended to any playlist or to a new playlist from the playlist view itself.

It'd be good to be able to move an album to any playlist from the collection / file manager :

 * Append to current
 * Append to another PL >
 * * playlist 2
 * * playlist 3
 * * New playlist
 * Toggle Queue
 * Rating : ***** (collection only)
 * Send to trash (file manager only)
 * Open folder in file manage (both)

I hope we can discuss and fix this for 0.3.0.

[[e-mail] (larsoner)]

I found a duplicate bug:
https://bugs.launchpad.net/ubuntu/+source/exaile/+bug/339126

Some music players give you the option of setting the default double-click action to be "replace" instead of "enqueue". This is my preferred method of listening to music, so it would be great if the feature were in Exaile.

[Steve Dodier-Lazaro (sidi)]

Anyone who is willing to produce a complete design guideline or a patch for this bug report should assign it to oneself.

[Rob McAuley (rmcauley)]

With the help of reacocard in #exaile, I've developed a patch to add this feature.

The patch adds:
- A context menu item to "Replace Current Playlist"
- Middle click in collection adds (currently not working, as something is capturing middle click before the press_button function can get it)
- A playlist preference changing the double-click action to replace instead of append by default

[[e-mail] (larsoner)]

Awesome. Can't wait.

On Tue, Sep 15, 2009 at 21:09, Rob McAuley <email address hidden> wrote:
> With the help of reacocard in #exaile, I've developed a patch to add
> this feature.
>
> The patch adds:
> - A context menu item to "Replace Current Playlist"
> - Middle click in collection adds (currently not working, as something is capturing middle click before the press_button function can get it)
> - A playlist preference changing the double-click action to replace instead of append by default
>
> ** Attachment added: "Add replace currently playlist functionality"
>   http://launchpadlibrarian.net/31871417/exaile-replace.diff
>
> --
> 'Replace playlist' action
> https://bugs.launchpad.net/bugs/136009
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Exaile: Confirmed
>
> Bug description:
> Exaile has only the option to add files to the current playlist. After listening to one CD, I'd like to be able to select another one and right-click->replace playlist...
>
> Cheers!
>
> -H-
>
>
> This ticket was migrated from the old trac: re #362
>

[Rob McAuley (rmcauley)]

There's still some work left to be done, including a bug reacocard found"

- Replace the playlist with any item from your collection
- Replace the playlist with the same item from your collection
- Repeat the same action again

What happens is the playlist is not cleared before replacing, meaning the item from your collection is now appended to the playlist. This happens every second replacement - essentially, if the playlist contains the exact same contents that you're importing, it will append instead of replace.

Even more bizarrely, the more often you use the Replace or Append function, the slower the collection responds to mouse clicks! This is completely unacceptable, so I'll need to figure out why my patch is making that happen. (if it is my patch)

The added menu item and preference are also going to need translation work on them done.

[Rob McAuley (rmcauley)]

The performance problems are not related to my patch. Still hunting the replacement bug.

[Rob McAuley (rmcauley)]

Actually the playlist isn't being appended to at all, it's a weirder bug than that:

- Replace your playlist with an item from the collection
- Replace with the same item again

Your playlist should now contain 1 copy of the item you selected from your collection. Try and play the item. You'll get a traceback:

Traceback (most recent call last):
  File "/home/rmcauley/exaile-dev/exaile03/xlgui/playlist.py", line 478, in on_row_activated
    index = self.playlist.index(track)
  File "/home/rmcauley/exaile-dev/exaile03/xl/playlist.py", line 541, in index
    return self.ordered_tracks.index(track)
ValueError: list.index(x): x not in list

It's not appending a 2nd copy to the playlist - the first copy doesn't exist in Exaile, yet it's displayed. You can also "stack" these visible-yet-non-existent items: once the phantom songs are displayed in the playlist, you can replace the playlist with something else, and the phantom songs will persist.

[Rob McAuley (rmcauley)]

Alright, back at work on this. This patch works against the latest bzr rev.

[Rob McAuley (rmcauley)]

I wonder if this GTK exception will help us:

/home/rmcauley/exaile-dev/exaile-rob/xlgui/playlist.py:781: GtkWarning: gtk_tree_path_append_index: assertion `index >= 0' failed
  self.list.set_cursor(lastindex - len(rows))
/home/rmcauley/exaile-dev/exaile-rob/xlgui/playlist.py:781: GtkWarning: gtk_tree_row_reference_new_proxy: assertion `path->depth > 0' failed
  self.list.set_cursor(lastindex - len(rows))

Could this be clue as to why the replace command is causing this strange behaviour?

[Rob McAuley (rmcauley)]

Bumping this bug -

Testing against the latest bzr version, the strange playlist bugs exhibited earlier do not seem to exist. Works for Me(tm). The patch also works completely.

Could one of the devs test further for possible inclusion in 0.3.2?

[Mathias Brodala (mathbr)]

Fixed with r2999.