Cover manager (gui): wrong count of cover needed after fetching and compilation issues
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Exaile |
New
|
Undecided
|
Unassigned | ||
Bug Description
r4118
After fetching cover ends the text of the progress bar is updated with a wrong value.
That's cause in xlgui/covers.py the counting is made with the method _calulate_needed() that bases is count on those items of the dictionary " self.covers{} " which have as value "self.no_cover". The problem concerns the fact that the dictionary is not updated in the process of fetching made by the method " _find_covers() ". In that method should be added this line:
at line 284.
Another problem:
Manually fetching or removing a cover ( by clicking on Fetch or Remove of the Cover Menu) doesn't update the text in the progress: methods "remove_cover" and "on_cover_chosen" should call the method "_do_stop" ? This sounds simple but the main problem concerns the management of the compilations. In fact, compilations present various artists and for each pair artist-album the cover manager has an item. When you manually remove or fetch a cover for a pair artist-album of a compilation the other elements of the compilation, that have the same cover, are not interested in that session. The next time you run the cover manager all the items (pair artist-album) of that compilation are interested of that addition/removal.
