Holding template creation fails in holdings editor in 3.8

[Elaine Hardy]

In 3.8

Holding template creation fails when attempting to create a new template in the holdings editor. No template by that name exists in list, even after logging off and back into Evergreen. Also does not appear in exported template file.

When clicking save after defining attributes and naming template, no console messages are generated. No errors, no generic messages

See attached screen shots

[Jennifer Pringle (jpringle-u)]

I was able to create a template in the Holdings Editor but it didn't display in the list initially.

When I went into Administration -> Local Administration -> Holdings Template Editor the template showed in the drop down there. I then log out and back in, created additional templates in the Holdings Template Editor, logged out and back in, and then all of my templates showed in the Holdings Editor.

[Jennifer Weston (jweston)]

I am seeing the same results as Elaine. (also noted in bug #1951162)
Created template in Holdings Editor and there is no indication that it saved. New template was not immediately visible in either place. Logged out and back in, still not visible in Holdings Editor or Local Admin-> Holdings Template Editor.

[Jennifer Weston (jweston)]

Confirming results reported by Jennifer Pringle. The extra step I was missing was the need to create additional templates in Local Admin > Holdings Template Editor (and then log out and back in) to make all templates show.

[Galen Charlton (gmc)]

Noting from a bug I filed yesterday that's more or less a duplicate of this one (and which I'll mark as such), the technical description of the problem:

"The Angular Holdings editor retrieves templates from a server-side setting (cat.copy.templates), but saves them to as a local storage item (key also cat.copy.templates).

As a consequence, users can see the templates that they created in the AngularJS holdings editor, but any changes they make would not appear to take effect. Somebody starting from a fresh database would appear to be able to save templates, but they wouldn't actually persist."

[Galen Charlton (gmc)]

A patch is available in user/gmcharlt/lp1957179_fix_holdings_template_saving / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1957179_fix_holdings_template_saving

[Mary Llewellyn (mllewell)]

Logged into https://terran-testbox.gapines.org/eg2/en-US/staff with admin/br1.

I was able to add several templates in the Angular Holdings Editor. Closed and re-opened and the list of templates was still there. Logged out and logged back in the the template list was still visible in the Angular Holdings Editor.

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>

[Michele Morgan (mmorgan)]

Works for me, too!

Pushed to master, rel_3_9 and rel_3_8.

Thanks Galen and Mary!