Adding item alerts in item attributes fails

[Elaine Hardy]

In 3.8

Adding item alerts in Holdings view via the holdings editor -- item attributes, consistently fails.

In the dialog box to add Item Alerts, clicking Add New closes the box without saving the alert.

Bypassing it and clicking on Apply changes, does nothing -- the dialog box doesn't auto close and no alert is created if you manually close the box and save all changes

[Elaine Hardy (ehardy)]

This may have partially been a config issue with our test server. With that fixed, I am seeing item alerts saving, however, the dialog box doesn't behave as expected.

Clicking on add new closed the box, preventing user from adding another alert. (alert appears to be added)

Clicking on apply changes, the box must be closed manually. (alert appears to be added)

Expected behavior is for add new box to add the new note, leaving the dialog box open for any other action. And for Apply changes to apply the new alert and close the dialog box

[Elaine Hardy (ehardy)]

May be realted to https://bugs.launchpad.net/evergreen/+bug/1959716

[Jennifer Pringle (jpringle-u)]

Item alerts are added as expected for me (as long as I'm not using the unified editor) in 3.8

[Jennifer Pringle (jpringle-u)]

To qualify my above comment, I can successfully add alerts but I agree with Elaine that the Item Alerts pop up isn't working as expected.

"Clicking on add new closed the box, preventing user from adding another alert. (alert appears to be added)" - I see this too

"Clicking on apply changes, the box must be closed manually. (alert appears to be added)" - when I click "Apply Changes" which appears to do nothing and than click "Close" or the X in the upper right corner my alert is not saved.

Existing alerts don't display when creating an item - ie. if I add an alert, make another change in the editor, and then click Item Alerts my alert does not display. You should be able to edit item alerts while you're creating an item (and you can with the old editor) in case you add the wrong alert by accident. If I save the item and then go back into the holdings editor and click Item Alerts it now displays the existing notes as well as a space for me to add a new note.

Also of note, the Manage Item Alerts pop up from Item Status is the old pop up - https://bugs.launchpad.net/evergreen/+bug/1960883

[Jennifer Pringle (jpringle-u)]

I didn't make any changes but now when I go click on Item Alerts when creating a new item it appears at the bottom of the page and is un-usable. The same thing is happening for me with Item Notes and I've created a bug for that - https://bugs.launchpad.net/evergreen/+bug/1960884

[Christine Burns (christine-burns)]

persists in 3.9

[Mary Llewellyn (mllewell)]

I'm finding that the alert type doesn't display after the alert has been created.

[Galen Charlton (gmc)]

Patches are available in the branch user/gmcharlt/lp1956986_ang_item_alerts / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1956986_ang_item_alerts

This branch also includes a patch for bug 1978889.

[Bill Erickson (berick)]

Follow up to Galen's branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1978889-copy-alerts-various-fixes

1. Add sign offs

2. Fixes an issue where "ack_staff" was not successfully applied when invoking the copy alerts dialog from the catalog Holdings View.

3. Related to testing this bug, I noticed the Holdings View in the catalog copy alerts count column included copy alerts that had already been ACK'ed. Patch included to avoid counting ACK'ed alerts.

[Elaine Hardy (ehardy)]

Is #3 this bug? -- https://bugs.launchpad.net/evergreen/+bug/1843087

[Bill Erickson (berick)]

Yes, thanks Elaine! I've added a comment to bug #1843087

[Elaine Hardy (ehardy)]

I tested this in Firefox on https://terran-testbox.gapines.org

I was able to successfully add item alerts and the alert editor acted as expected. Clicking the apply button in the alerts editor kept the box open. Clicking on apply changed closed the box and saved the alert.

The counter also reset the number of alerts if I deleted one or all.

The alert type is not displaying but I don't know if that is addressed in this patch or if we need to open another report for it.

If the alert type displaying is not part of the patch on terran-testbox, then I have tested this and consent to signing off with my name, Elaine Hardy, and email <email address hidden>

[Terran McCanna (tmccanna)]

(Note that I missed Galen's commit when I first applied this to the test server. After applying it, Elaine re-tested that part successfully as well.)

[Bill Erickson (berick)]

Thanks, All! Merged to 3.8 and up.