Editing call number for reserve item requires refresh

[Beth Willis]

When associating an item with a course, there is an option to edit the item’s call number. If this option is selected, a new call number is entered and the “Add Material” button is selected, the new call number does not display in the grid on the Course Materials tab. The screen must be refreshed in order to see the updated call number.

EG 3-6-1

[Jane Sandberg (sandbergja)]

Confirmed! Pull request at user/sandbergja/lp1907974_refactor_course_item_updater

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1907974_refactor_course_item_updater

Here are the testing notes from the commit message:

1) Go to Local Admin > Course List
2) Double click on a course
3) Go to the materials tab
4) Add an item by barcode, making sure to supply a temporary call
   number, and that the call number checkbox is checked.
5) Note that the grid on the right display's the item's old call number,
   not its new one.
6) Apply this patch.
7) Repeat step 4. Note that the temporary call number is reflected in
   the grid now.

[Jane Sandberg (sandbergja)]

Removing pullrequest for now, since I found an error.

[Jane Sandberg (sandbergja)]

Fixed the error that I found, and force-pushed the code to user/sandbergja/lp1907974_refactor_course_item_updater

[Beth Willis (willis-a)]

I tested this fix on Equinox Test Server #2. First, I created a new course. Then, I added two items to the course, assigning a temporary call number to each. The updated call number displayed on the course page without a manual refresh.

I am signing off on it with my name, Beth Willis, and my email address, <email address hidden>.

[Michele Morgan (mmorgan)]

I'm getting an error compiling the angular files after applying the commit at the top of https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1907974_refactor_course_item_updater

Here's the error:

Error: src/app/staff/share/course.service.ts:229:26 - error TS2345: Argument of type '(res: any) => Observable<any> | ((error: any, scheduler?: SchedulerLike) => Observable<never>)' is not assignable to parameter of type '(value: any, index: number) => ObservableInput<any>'.
  Type 'Observable<any> | ((error: any, scheduler?: SchedulerLike) => Observable<never>)' is not assignable to type 'ObservableInput<any>'.
    Type '(error: any, scheduler?: SchedulerLike) => Observable<never>' is not assignable to type 'ObservableInput<any>'.
      Property '[Symbol.iterator]' is missing in type '(error: any, scheduler?: SchedulerLike) => Observable<never>' but required in type 'Iterable<any>'.

229 ).pipe(switchMap(res => {
                             ~~~~~~~~

  node_modules/typescript/lib/lib.es2015.iterable.d.ts:51:5
    51 [Symbol.iterator](): Iterator<T>;
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    '[Symbol.iterator]' is declared here.

[Jane Sandberg (sandbergja)]

Wow, what a cryptic error for a simple solution. Instead of calling `throwError` and returning its results, I was trying to just return the function itself!

I pushed a small commit to fix that to the same branch, user/sandbergja/lp1907974_refactor_course_item_updater. It is also now rebased.

[Gina Monti (gmonti90)]

I, Gina Monti, sign off on this bug. The new call number displays in the Course Materials grid when a temporary call number is added.

[Michele Morgan (mmorgan)]

Works great to fix an annoying problem for Course Reserve administrators!

Pushed to master, rel_3_9 and rel_3_8

Thanks Jane, Beth and Gina!