Evergreen

Bootstrap opac: Google Books preview not working

Bug #1955403 reported by Garry Collum
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 3.10.1
3.9
Fix Released
Medium
Unassigned
Evergreen 3.9.2

Bug Description

In the bootstrap opac setting ctx.google_books_preview to true or 1, has no affect. Neither the Google Book preview button, or the preview are rendered.

The easiest way to confirm in the concerto data is to enable google_books_preview, and change an existing ISBN to an isbn for which you know there is a google book preview. Two such ISBNs are 9788027103782 and 9781629795645.

Revision history for this message
Garry Collum (gcollum) wrote :

A proposed fix is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=3d29e055ebabcba5bafaf5f6006f3e1661b08f18

tags: added: pullrequest
Christine Morgan (cmorgan-z)
Changed in evergreen:
status: New → Confirmed
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.8.1
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.8.1 → none
Revision history for this message
Eva Cerninakova (ece) wrote :

I have tested Google Book preview using the https://festivus.evergreencatalog.com.

I have found few records with Google Books button, that opens the Google Books preview. Also, the control of the preview in the embedded window works without problems.

Revision history for this message
Eva Cerninakova (ece) wrote :

I have tested this code and consent to signing off on it with my name, Eva Cerniňáková and my email address, <email address hidden>.

Jason Boyer (jboyer)
tags: added: signedoff
Terran McCanna (tmccanna)
Changed in evergreen:
milestone: none → 3.9.1
Evergreen Bug Maintenance (bugmaster)
no longer affects: evergreen/3.7
Changed in evergreen:
milestone: 3.9.1 → 3.9.2
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed for inclusion in 3.10 and 3.9. Thanks, Garry and Eva!

Changed in evergreen:
milestone: 3.9.2 → 3.10.1
importance: Undecided → Medium
Galen Charlton (gmc)
Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.