GitHub reference can fail for npm install for AngularJS client

Bug #1937875 reported by Adam Bowling
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.5
Undecided
Unassigned
3.6
Undecided
Unassigned
3.7
Undecided
Unassigned
3.8
Undecided
Unassigned

Bug Description

package.json in $EVERGREEN_ROOT/Open-ILS/web/js/ui/default/staff/ references the dependency "angular-order-object-by": "github:rxfork/ngOrderObjectBy#npm". This can cause npm install to fail by attempting ssh where keys are not setup on the server. npm now has an officially recognized package. Changing the code to remove the reference.

Revision history for this message
Adam Bowling (abowling) wrote :
tags: added: pullrequest
Revision history for this message
Jason Boyer (jboyer) wrote :

Does the thing; pushed to master-3.5 with minor typo correction and a reformatted release note.

no longer affects: evergreen/master
Changed in evergreen:
milestone: none → 3.next
milestone: 3.next → none
status: New → Fix Committed
tags: added: signedoff
Changed in evergreen:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers