MARC_NAMESPACE in AppUtils should be constant

Bug #1930747 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.6
Undecided
Unassigned
3.7
Undecided
Unassigned

Bug Description

The "my" variable $MARC_NAMESPACE added to OpenILS::Application::AppUtils as part of the work for bug 1881607, should be a constant and not a variable. Making it a constant protects it from accidental change and better conveys the intent of how it is to be used.

There's also an argument to be made for moving it to Const.pm where it could be exported to other modules.

Revision history for this message
Jason Stephenson (jstephenson) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.8-beta
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers