Date columns in Acq Search should show timestamps

Bug #1912097 reported by Tiffany Little
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
3.7
Low
Unassigned

Bug Description

3.6+

In the new Angular Acquisitions Search, the date columns are showing simply as dates. In previous versions, they showed as timestamps. This was much more useful, since it was good to see exactly when a purchase order was created or ordered, invoices were closed, etc.

Fields that this applies to:

Purchase Order-Creation Time
Purchase Order-Edit Time
Purchase Order-Order Date
Line items-Creation Time
Invoice-Invoice Date
Invoice-Close Date
Selection List-Creation Time
Selection List-Edit Time

Revision history for this message
Jane Sandberg (sandbej) wrote :

This should just require adding [datePlusTime]="true" to the relevant <eg-grid-column> definitions.

tags: added: bitesize
Revision history for this message
Tiffany Little (tslittle) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.6.2
Mike Risher (mrisher)
Changed in evergreen:
assignee: nobody → Mike Risher (mrisher)
Revision history for this message
Mike Risher (mrisher) wrote :

I've checked all the fields listed in the bug description, and see they all have both time and date. I don't see any unwanted side effects. I've tested and I consent to sign off on this with my name Mike Risher and email <email address hidden>

tags: added: signedoff
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Mike Risher (mrisher)
Changed in evergreen:
assignee: Mike Risher (mrisher) → nobody
Revision history for this message
Jane Sandberg (sandbej) wrote :

Works well for me. Thanks, Tiffany and Mike. However, Tiffany, your original commit is missing your signoff. Could you please add that (once you are on the correct branch, it should be git commit --amend --signoff).

Changed in evergreen:
importance: Undecided → Low
status: New → Confirmed
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Revision history for this message
Tiffany Little (tslittle) wrote :

Hi Jane, I think I've fixed the signoff issue. Please let me know if there's any issue with it. Thanks!

Revision history for this message
Jane Sandberg (sandbej) wrote :

Thanks, Tiffany and Mike! Pushed to rel_3_6, rel_3_7, and master.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers