Vandelay: cannot overlay a specified matched record

Bug #1842763 reported by tji@sitka.bclibraries.ca
44
This bug affects 19 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.3
Medium
Unassigned
3.4
Medium
Unassigned
3.5
Medium
Unassigned
3.6
Medium
Unassigned
3.7
Medium
Unassigned

Bug Description

EG 3.3 the new Vandelay interface

The old behaviour: (we use 3.1.7)

When a loaded record matches multiple existing records, we may specified a target to merge with or let EG pick up one based on the selected merge option checkboxes.

On the new Interface, we still can specified a target. But after clicking Import Selected Records or Import All Records, it reverts back to the MARC File Upload screen, instead of the Import Item popup on the old interface. The Upload button is inactive (The label Upload is confusing. It should be Import here.) unless at least one of the 4 merge options is selected. It appears these options ignore the selected merge target during the import. EG will pick up a target based on the selected merge options. For example, one of test case have 4 matched records with match score ranging from 100 to 600. I chose one record with 100 score as the merge target. I selected all the 4 merge options. The record with 600 match score was merged.

Considering the scenario of importing multiple bibs at one time, I think by default EG should use the specified merge target, use the target based on the merge options when there is no selected target. This means the "Upload" button should not be set inactive when no merge option is selected. That being said, I still prefer the old Import Item popup screen. I found using the MARC File Upload screen is confusing.

Jane Sandberg (sandbej)
tags: added: angular vandelay
Remington Steed (rjs7)
summary: - Vandelay: cannot overaly a specified matched record
+ Vandelay: cannot overlay a specified matched record
tags: added: regression
Changed in evergreen:
importance: Undecided → High
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Selecting a specific matching record for overlay works in the old Vandelay UI and looks like it is supposed to be supported in Angular (you can view matching records and select a match target, it just doesn't actually do anything). It seems like an important feature, so I've marked this bug as a High priority.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

A fix for this bug will probably require a fix for bug 1843837 too.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

I'm bumping this down to Medium priority because there is a workaround: if you select Import Non-Matching Records, your selected records will be used as merge targets.

Here's the full workflow:

1. Go to the MARC File Upload screen (Cataloging > MARC Batch Import/Export > Import tab).
2. Create a queue and select a record match set. Do NOT check any of the four match checkboxes.
3. Upload a file that will match multiple existing records with different match scores.
4. Click Upload. This will upload your file and populate your queue, but won't import anything yet.
5. Once your file has been uploaded, click Go to Queue.
6. Click on the link in the Matches column to view your record matches.
7. Click on the Merge Target cell for the record you want to merge. A circle with a checkmark appears, indicating that this is your merge target. (Don't use the checkboxes, they are not useful here and should probably be suppressed.)
8. Click on Return to Queue. The Matches column now shows an asterisk next to the number of matches, indicating that a match has been selected.
9. Check the checkbox for your test record and click on Import Selected Records. This will return you to the MARC File Upload form.
10. Select a merge profile and check Import Non-Matching Records.
11. The Upload button is now enabled. Click it, and your record will be imported.
12. Click on Go to Queue to see the results. The Imported As column contains a link to the overlaid record, which should be the merge target you selected in step 7.

In step 10, it should not be necessary to check Import Non-Matching Records. If I've selected merge targets, I am not importing "non-matching" records; the records have been matched manually. Vandelay should allow the import to proceed without specifying any other match-related import action, as the old Dojo UI does.

Changed in evergreen:
importance: High → Medium
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Fixes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1842763-vand-allow-import-from-selection

From commit:

Allow the user to process selected queued records, which may or may not have an overlay target selected, without requiring an import action be selected. In the case of records with overlay targets, the import action (overlay selected target) is implicit, so there's no need to select an action.

Additionally, when an import selection has been defined, change the action button from "Upload" to "Import", since we're past the upload stage at this point.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: New → Confirmed
milestone: none → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.5.0
Changed in evergreen:
milestone: 3.5.0 → 3.5.1
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Changed in evergreen:
assignee: nobody → Christine Morgan (cmorgan-z)
Revision history for this message
Christine Morgan (cmorgan-z) wrote :

I was able to successfully overlay a selected record when multiple matches are found, but did find one issue.

The selected values for "Select or Create a Queue" and "Record Match Set" are not being retained for the Import process. After setting those values for the Upload process, I found that I had to reset them before clicking the Import button. The dropdowns are greyed out as if they are set, but the default values appear instead of the selected ones (See screenshot). Currently those values are retained in the form throughout the upload and import processes.

I did not test if the "Record Type" (if changed from Bibliographic),"Holdings Import Profile" and "Limit Matches to Bucket" selections were retained.

Changed in evergreen:
assignee: Christine Morgan (cmorgan-z) → nobody
tags: added: needsrepatch
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
tags: removed: pullrequest
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → none
Revision history for this message
Jennifer Weston (jweston) wrote :

Bug for not retaining the queue name and record match set (and holdings import profile) filed separately on 2021-03-04; Bug #1917775 (https://bugs.launchpad.net/evergreen/+bug/1917775) -- I will mark the newer one as a duplicate.

Revision history for this message
Jennifer Weston (jweston) wrote :

See details for workaround for reselecting values documented in Bug #1917775

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

I'm also seeing the issue from comment #5 on a 3.7 server with the fixes from comment #4 applied. It looks like state is not being maintained when we move between the Import and Inspect Queue tabs. The workaround from the duplicate bug (using the dropdown arrows to select a queue) works for me even though the dropdown is "disabled," but of course it shouldn't be necessary to re-select a queue to complete the import.

Interestingly, I *don't* see this issue on a server running 3.5.2-ish: there, my initial selections on the Import screen are retained when I return there after inspecting the queue and selecting records to import.

Revision history for this message
Bill Erickson (berick) wrote :

New rebased branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1842763-vand-allow-import-from-selection-v2

It improves target selection and propagation of selection info between queue and import UI's.
Also adds a "select all" option to the queue page.
It also includes a number of Combobox fixes/additions.

Michele Morgan (mmorgan)
tags: added: pullrequest
removed: needsrepatch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers