webclient offline : expired patrons should show date of block list download

Bug #1752356 reported by Andrea Neiman
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.3
Medium
Unassigned
3.4
Medium
Unassigned
3.5
Medium
Unassigned
3.6
Undecided
Unassigned
3.7
Undecided
Unassigned

Bug Description

In the XUL client, if you have downloaded the Offline Block List and attempt an offline checkout with an expired patron, you get this message:

Warning: as of DATE, this barcode (nnnnnn) was flagged Expired.

(note that DATE is the download date, not the date the patron was marked expired).

In the web client, you are informed that the patron is Expired but without the date reference.

Having the date reference is a helpful indicator to know when the block list was downloaded & would be nice to incorporate into the web client's offline mode.

I'd recommend a wording adjustment so it's more clear that the date referenced is the download date, and it would be extra great to have this wording show on all blocked patrons in Offline.

Revision history for this message
Andrea Neiman (aneiman) wrote :
description: updated
Revision history for this message
Erica Rohlfs (erohlfs) wrote :

Confirmed on 3.0.3 I also agree that displaying the last download date is a very helpful troubleshooting tool (and training tool).

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Mike Risher (mrisher)
Changed in evergreen:
assignee: nobody → Mike Risher (mrisher)
Revision history for this message
Mike Risher (mrisher) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Mike Risher (mrisher) → nobody
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, All. I have pushed a branch with a sign off for Mike's patch, plus an additional commit.

From the commit msg:

Modify wording to clarify the date displayed is that of the block list download and not necessarily the date the patron was flagged expired.

Avoid console errors when the file download date is not known -- edge case where the code is updated but the block list was not updated in the meantime.

Clean up some debug logging.

==

I also took the liberty of tweaking Mike's commit message to suit community standards (LP number, formatting).

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1752356-offline-block-patron-exp-date

Changed in evergreen:
milestone: none → 3.3.3
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.1
Revision history for this message
Terran McCanna (tmccanna) wrote :

Mike / Bill - I am hitting some errors when I apply this to a test server running current master. Could you please rebase?

tags: added: needsrepatch
Revision history for this message
Mike Risher (mrisher) wrote :
tags: removed: needsrepatch
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Revision history for this message
Mike Risher (mrisher) wrote :
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks, Mike and Bill. I found in testing that the new message had been applied to accounts marked Barred rather than accounts marked Expired, so my sign off is here with that correction. I've also taken the liberty of adding similar wording (as per Bill's commit) to the other reasons "WHY" accounts can appear on the block list.

A signoff on my changes would be most appreciated.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1752356-offline-block-list-download-date

Revision history for this message
Mike Risher (mrisher) wrote :

Thank you for the improvement, Terran. I tested each of the 4 error messages you can get when trying to check out a patron on the block list. They all look good to me. I consent to signing off to this with my name Mike Risher (<email address hidden>)

Mike Risher (mrisher)
tags: added: signedoff
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
milestone: 3.6.1 → 3.next
Changed in evergreen:
milestone: 3.next → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
tags: removed: webstaffclient
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Jason Boyer (jboyer)
Changed in evergreen:
assignee: nobody → Jason Boyer (jboyer)
Revision history for this message
Jason Boyer (jboyer) wrote :

Pushed to rel_3_6 through master; thanks everyone!

Changed in evergreen:
assignee: Jason Boyer (jboyer) → nobody
Jason Boyer (jboyer)
Changed in evergreen:
status: Confirmed → Fix Committed
milestone: 3.7.2 → 3.8-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers