Multiple issues with the Collections: Exempt user setting

[Jason Boyer]

Affects Evergreen 3.6+ or all supported versions (depending on database age)

The patch for bug 1615800 accidentally lost the .label() for the circ.collections.exempt user setting in the user editor, causing the whole JS dictionary to be used as the label. This can easily go unnoticed because the circ.collections.exempt user setting was never added to the seed data, so it's only visible on databases old enough to have had the upgrade script run for that setting.

Incoming is a branch to add the user setting to the seed data, add it to the db if missing, and fix the display in the user editor.

[Jason Boyer (jboyer)]

Here we go:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1937299_collections_exempt / working/user/jboyer/lp1937299_collections_exempt

Depending on your database age and Evergreen version there are 3 potential possibilities pre-patch:

1. Database less than ~10 years old; you likely don't have this setting at all and there is no indication of anything missing in the user editor.

2. Database more than ~10 years old and Evergreen 3.6.3 or 3.7.0 or older; you should see the Collections: Exempt user setting in the patron editor down near the holds notification settings.

3. Database more than ~10 years old and Evergreen 3.6.4 or 3.7.1 or newer, where the Collections: Exempt user setting should appear you'll see a javascript dictionary similar to {"a":["circ.collections.exempt","Collections: Exempt","User is exempt from collections tracking/processing","bool",null,null,"f",null],"classname":"cust","_isfieldmapper":true} to the left of the checkbox. The setting will still work, but the label is a mess.

Post-patch, in all 3 instances the Collections: Exempt setting will appear where expected near the user hold notification settings.

[Terran McCanna (tmccanna)]

I can confirm that the user setting now appears as expected in Server Administration > User Setting Types and the label is now correctly displayed in the user editor. My sign off is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1937299_collections_exempt_signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_7, and rel_3_6. Thanks, Jason and Terran!