Angular catalog: missing "View Basket" functionality

Bug #1899406 reported by Michele Morgan
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Undecided
Unassigned
3.5
Won't Fix
Undecided
Unassigned

Bug Description

In the traditional staff catalog, the user can choose View Basket and perform functions on selected titles in the basket, while maintaining all the titles in the basket.

In the angular catalog, when the user chooses to view the basket, deselecting titles to perform actions on a subset of titles removes the deselected titles from the basket.

tags: added: staffcatalog
Bill Erickson (berick)
Changed in evergreen:
status: New → Confirmed
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1899406-staff-cat-view-basket-selection

From the commit:

In the Angular staff catalog, support applying basket actions to selected items within a basket, without selection/desection impacting the contents of the basket.

Note that 'Export All Basket Records' applies to the entire basket and is not affected by the selection. All other actions, besides View and Clear Basket, are affected by the selection.

--

Note the new Export option does not have a UI entry point at this time for exporting specific records, though one could be added.

Changed in evergreen:
milestone: none → 3.6.1
tags: added: regression
tags: added: pullrequest
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Bill Erickson (berick)
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
assignee: nobody → Christine Morgan (cmorgan-z)
Revision history for this message
Christine Morgan (cmorgan-z) wrote :

After adding 20 titles to the basket, I was able to click View Basket and deselect some or all titles without losing the titles from the basket. That part works well. However, I missed having the "Select" checkbox within the basket view that would allow me for example, to take a print or email action on say, an individual record, without having to deselect all the other titles individually. Just one instance where the Select checkbox would be most useful.

Changed in evergreen:
assignee: Christine Morgan (cmorgan-z) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

I agree that it works well, but the addition of a select all / deselect all box at the top would make it even more useful. Should this be signed off as-is and a new wish list item be created for the select all/deselect all box?

Revision history for this message
Elizabeth Thomsen (et-8) wrote :

I with Christine and Terran that the select all / deselect all box is useful -- I would say important, but would rather see this get in as is and open a new wish list item if the alternative would possibly delay the whole thing

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Here's a rebased branch with the additional select / deselect all option within the basket view:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1899406-staff-cat-view-basket-selection-v2

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
tags: added: needsrepatch
Revision history for this message
Terran McCanna (tmccanna) wrote :

Needs a fresh rebase - getting conflicts on basket-actions.component.html and
basket-actions.component.ts

Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

I was able to resolve the conflicts in Bill's branch and did some testing of the Basket View. The functionality is getting there, but one thing I am finding confusing is that the same menu applies both to the currently selected records in Basket View as well as to the entire basket.

Using the same menu for both contexts makes it unclear whether the chosen action will be performed on the selected titles in the Basket View or on the entire basket. Can there be a separate menu for the Basket View? If not a separate menu, maybe change the labels when in Basket View, and grey out the choices that are only intended to act on the entire basket? I'll attach a couple of screenshots.

A couple other observations in Basket View:

The select/deselect checkbox is a great addition, but can it be moved to the left, in line with the checkboxes for the individual records?

When selecting a subset of records and choosing to Place Hold or Export All Basket Records, if you click Return to go back to Basket View, all the records are now selected (instead of the subset).

I'm adding a link to the branch I was testing where conflicts are resolved.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1899406_conflicts_resolved

Revision history for this message
Michele Morgan (mmorgan) wrote :

Screenshot of Basket Actions menu that applies to entire basket.

Revision history for this message
Michele Morgan (mmorgan) wrote :

Screenshot of Basket View using the same Basket Actions menu.

Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Revision history for this message
Terran McCanna (tmccanna) wrote :

I agree with Michele's comments about the actions menu needing some additional clarification

tags: removed: pullrequest
tags: added: needswork
removed: needsrepatch
tags: added: baskets
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
no longer affects: evergreen/3.6
Changed in evergreen:
milestone: 3.7.3 → none
Revision history for this message
Michele Morgan (mmorgan) wrote :

Attempting to resurface this. Here's a rebased branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1899406_rebase

user/mmorgan/lp1899406_rebase

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.