SMS Carriers display in ID, not alphabetical order

[Chris Sharp]

Reported by a PINES library:

When placing a hold for a patron and selecting notifcation options, the list of SMS carriers is listed in database ID order, which makes it cumbersome for staff to select the correct carrier from the list. The list should be in alphabetical order.

Evergreen 3.0
OpenSRF 3.0
PostgreSQL 9.5
Ubuntu 16.04

[Garry Collum (gcollum)]

A proposed patch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1809157-SMS-Carriers-not-in-alpha-order

[Michele Morgan (mmorgan)]

I don't see this issue when placing a hold as a patron. I also do not see the issue when placing a hold as a staff user.

I do see the issue when selecting an existing hold on a patron record while logged in as a staff user and choosing Edit Notification Settings.

Garry's patch does fix the sorting issue, but I've also discovered that the list of SMS carriers in the affected interface also does not filter out SMS carriers where Active is False.

If filtering out the inactive carriers is a quick fix, it would be good to include it. Otherwise, I'm prepared to sign off on the sorting issue and open another bug for the filtering.

[Terran McCanna (tmccanna)]

Michele - I'd be in favor of signing off on the sorting fix and opening a separate bug for the filtering.

(FYI, the filtering only seems to be a problem on the Edit Notification Settings dropdown. It appears to filter correctly in the Place Hold for Patron pge.)

[Michele Morgan (mmorgan)]

Thanks for weighing in Terran! I've added my signoff here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1809157_signoff

I'll open a new bug for the filtering issue.

[Galen Charlton (gmc)]

Pushed to master, rel_3_7, and rel_3_6. Thanks, Garry and Michele!