deleting an item does not remove its copy tags

Bug #1761615 reported by Jason Etheridge
34
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Medium
Unassigned

Bug Description

And this impacts searching for digital bookplates (a bib can be retrieved through such a search with no visible sign of a matching bookplate).

Beth Willis (willis-a)
tags: added: copy-tags item-tags
Revision history for this message
Beth Willis (willis-a) wrote :

Confirmed on EG 3-2-0

Changed in evergreen:
status: New → Confirmed
Andrea Neiman (aneiman)
tags: removed: copy-tags
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Chris Sharp (chrissharp123) wrote :

I have a branch that works for me in removing item tag mappings upon item deletion:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1761615_delete_copy_tags_on_copy_delete

To test:
1) add copy tags to an item
2) verify from the database end that the copy tags were created (asset.copy_tag) and mapped (asset.copy_tag_copy_map).
3) delete the item - you will see the asset.copy_tag_copy_map rows still in place
4) apply this fix
5) repeat steps 1-3 and verify that the asset.copy_tag_copy_map rows are now gone.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.6.1
Revision history for this message
Beth Willis (willis-a) wrote :

I have tested this code and consent to signing off on it with my name, Beth Willis and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Revision history for this message
Galen Charlton (gmc) wrote :

Noting that the rest of the item deletion code intentionally does _not_ cascade deletes to things like alerts, statistical categories, and notes so that they remain available for reporting purpose and revival if the item gets undeleted.

Consequently, would an suitable alternative be making catalog search ignore deleted items and call numbers when searching on item tag?

tags: added: needsdiscussion
Galen Charlton (gmc)
tags: removed: needsdiscussion
Changed in evergreen:
status: Confirmed → Fix Committed
tags: added: needsdiscussion
Changed in evergreen:
status: Fix Committed → Confirmed
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Given the philosophy (or habit) in Evergreen of not deleting when not necessary I think we should be consistent and not actually delete tags. Suppressing them from search and display is a better path I think.

Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Revision history for this message
Bill Erickson (berick) wrote :

Removing pullrequest pending resolution on discussion.

tags: removed: pullrequest signedoff
tags: added: cat-itemtags
removed: item-tags
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
no longer affects: evergreen/3.6
Changed in evergreen:
milestone: 3.7.3 → none
Revision history for this message
Tiffany Little (tslittle) wrote :

I agree with Rogan's comment--I think we should be consistent. It makes more sense to me to suppress them from search and display. It also seems like it would be useful to have those reportable even after the copy is deleted. Jason's parentheses note seems like the real bug, IMO.

Revision history for this message
Elizabeth Thomsen (et-8) wrote :

I agree as well -- search is the problem, and depending on how these tags are used, these could be useful in reports to see, for example, all the books that were donated by the Professor Plum Foundation, including ones no longer in the collection.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.