webstaff: EXPAND_WEB_IMPORTS = 0 no longer works

[Galen Charlton]

As a consequence of the patches for bug 1739803, a minimized CSS file (e.g., evergreen-staff-client-deps.0.0.1.min.css) is no longer ever produced for the web staff client. As a consequence, setting EXPAND_WEB_IMPORTS to 0 (as was initially attempted in the branch for bug 1766716) no longer works at all, as it causes web staff client CSS to never be loaded.

Either EXPAND_WEB_IMPORTS should be remove entirely from the templates or CSS minification added back as an option.

Evergreen 3.1+

[Bill Erickson (berick)]

Since EXPAND_WEB_IMPORTS only affects CSS now, with webpack doing the JS-side aggregation, I propose we teach webpack to create evergreen-staff-client-deps.0.0.1.min.css, have the base template load it by default, and deprecate EXPAND_WEB_IMPORTS. Basically, the same thing we did with the JS. I don't see any particular benefit to loading the individual CSS files.

[Bill Erickson (berick)]

Branch pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1770212-webpack-for-css

This uses webpack for generating a combined, minified "vendor" css file. This file is imported by default in the base.tt2 template. The EXPAND_WEB_IMPORTS test has been removed. The individual CSS files are still copied into the web css directory if needed, but they will be unused unless explicitly referenced.

Installing this branch requires running 'npm update' in the staff JS directory.