web client: holdings view owning libraries not marked in drop down menu

[Elaine Hardy]

In holdings view, owning libraries are not marked in the drop down menu to choose libraries for display, as they are in the XUL client. When holdings run for several pages, having the holding libraries marked in that menu makes it much easier to find a library for holdings display

[Kathy Lussier (klussier)]

After almost eight years in the Evergreen community, I'm still learning about features in the xul client. I never realized that the library dropdown in holdings maintenance bolded the branches that owned a copy of the title. Confirming that we don't see the same behavior for the 'show holdings at or below' library dropdown menu in the web client's holdings view.

Thanks Elaine!

[Kyle Huckins (khuckins)]

I've pushed a branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1739277-bold-owning-libraries-in-holdings

The solution provides an additional bit of functionality: The ability to style entries in the Org Selector, using a new attribute: styleorg. With it, you pass in an object made up of orgArray(exactly what it says on the tin), and apply, which is a function that gets applied to the entries that correspond to the OU ids held in orgArray.

[Kyle Huckins (khuckins)]

I've pushed in a separate branch an update providing the same functionality to the eg2 Angular client: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1739277-holdings-view-owning-libraries-not-marked-angular

[Bill Erickson (berick)]

Hi Kyle, I have reviewed the branch and have a suggestion about how we apply the styling the individual org units.

I've pushed a branch with an alternate approach (for Angular) which allows the caller to pass in the CSS they wish to apply to each org unit instead of baking the style into the org selector itself.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1739277-org-select-class-callback

This allows for more flexibility (see sandbox example) and means we don't have to modify the actual org unit labels in the selector.

I'm pretty sure similar treatment could be done to the AngJS org select.

[Kyle Huckins (khuckins)]

That approach works much better, Bill, thanks. I've pushed a commit to implement it into the Angular Holdings View UI, and another to make the changes need to implement(as well as implementing it) into the AngJS Holdings View UI. Branch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/khuckins/lp1739277-org-select-class-callback

[Lynn Floyd (lfloyd)]

This works with the Angular version, but only in the AngJS version if the Experimental catalog is turned on.

[Terran McCanna (tmccanna)]

This one needs to be rebased before testing.

[Kyle Huckins (khuckins)]

Rebased version here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/khuckins/lp1739277-org-select-class-callback-v2

[Terran McCanna (tmccanna)]

This needs a fresh rebase - there is a new conflict since the last rebase where r.label is displayed on Open-ILS/src/eg2/src/app/share/org-select/org-select.component.html

[Kyle Huckins (khuckins)]

I've force-pushed a rebase resolving conflicts with two of the commits in this branch, should be good to test

[Jennifer Bruch (jbruchpails)]

Testing on the KCLS Server today and when I go to view an item and switch to Holdings View the Org Unit tree is automatically expanded to show the libraries that own a copy and those lines are a shaded slightly darker to highlight them.

I also the see the bolding of library branches that own a copy in the show holdings drop down, so it appears that the behavior is showing as expected.

I have tested and sign off on this fix.

Jennifer Bruch at PaILS/SPARK

[Jane Sandberg (sandbergja)]

Nice improvement! Thanks, Kyle, Bill, and Jennifer. I've pushed this to master, rel_3_7, and rel_3_8. I removed the 3.6 target, since we are only doing security releases for 3.6 now. I also opted not to push the AngJS commit, since the Angular catalog has been default since 3.6.