Web client- LSE Toggle off the patron summary sidebar after first view

[Christine Burns]

Library Setting - Toggle off the patron summary sidebar after first view is not working in the web client.

In XUL client when this setting is true, the patron summary sidebar will collapse after a new patron sub-interface is selected.

In the web client the patron summary stays open, you must click on hide button to hide the summary

[Bill Erickson (berick)]

Confirmed the org unit setting "circ.auto_hide_patron_summary" is not referenced in the web client.

[Katlyn Beck (klbeck)]

I've abstracted out the functionality in toggle_expand_summary() into a controller function. This is called when the summary expand button is pressed as well when there is a change in the "toggle off patron summary" library setting.

The branch can be found at:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=3131f7151ddaab6e0a4e43fc196bb1903868d989

[Katlyn Beck (klbeck)]

The previous link is incorrect. The branch can be found here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/klbeck/lp1717366-patron-summary-toggle

[Bill Erickson (berick)]

Thanks, Katlyn.

I have pushed a sign-off to your patch plus a follow-up commit to:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1717366-patron-summary-autocollapse

My commit treats "circ.auto_hide_patron_summary" as a plain org unit setting instead of a workstation setting for consistency with the XUL client. It also pre-caches the value at page resolve time for one less API call.

We could make this a "cascading" workstation setting, but that would require SQL seed data and that's arguably a separate LP ticket.

[Terran McCanna (tmccanna)]

Please rebase against current master. Thanks!

[Kyle Huckins (khuckins)]

As Katlyn's not working on Evergreen anymore, I performed the rebase: user/khuckins/lp1717366-patron-summary-autocollapse-rebase

[Kyle Huckins (khuckins)]

Oops, pasted the branch name when I meant to paste the url: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1717366-patron-summary-autocollapse-rebase

[Terran McCanna (tmccanna)]

In my testing, this change appears to do the opposite of what was intended. The first time I load a patron with this setting enabled, the summary bar is collapsed and then it stays open when I switch between the patron tabs.

[Kyle Huckins (khuckins)]

It appears to be working for me, but only with Hatch installed on my local machine

[Donna Rowland (drowland)]

STOP

On Mon, Oct 25, 2021 at 12:07 PM Andrea Neiman <email address hidden>
wrote:

> ** Changed in: evergreen/3.5
> Status: Confirmed => Won't Fix
>
> --
> You received this bug notification because you are subscribed to
> Evergreen.
> https://bugs.launchpad.net/bugs/1717366
>
> Title:
> Web client- LSE Toggle off the patron summary sidebar after first
> view
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 3.2 series:
> Won't Fix
> Status in Evergreen 3.3 series:
> Won't Fix
> Status in Evergreen 3.4 series:
> Won't Fix
> Status in Evergreen 3.5 series:
> Won't Fix
>
> Bug description:
> Library Setting - Toggle off the patron summary sidebar after first
> view is not working in the web client.
>
> In XUL client when this setting is true, the patron summary sidebar
> will collapse after a new patron sub-interface is selected.
>
> In the web client the patron summary stays open, you must click on
> hide button to hide the summary
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1717366/+subscriptions
>
>

--

______________________________________________________________
Be careful when you follow the Masses....Sometimes the 'M' is silent.

Donna Rowland (<email address hidden>)

Finance Specialist

Fontana Regional Library

33 Fryemont Rd.

Bryson City, NC 28713

Voice: 828-488-2382 ext.124

Fax: [phone]

“Opinions expressed in this message may not represent the policy of my
library. All e-mail sent to or from the Fontana Regional Library e-mail
systems is subject to monitoring and disclosure to third parties, including
law enforcement personnel.”