Web Client: Search Type included in search box and multiplies when sorting

[Jennifer Pringle]

Evergreen 3.3

When doing a search from the Basic or Advanced search in either the OPAC or the client the search Type (Title, Journal Title, Author, Subject, Series) is added to the search bar. The only type this doesn't happen with is Keyword. (In 3.1 the type is included in the searches from the advanced screen but not from the basic search.)

If you sort your results the search type is added again every time you sort. (This doesn't happen in 3.1)

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1839684-repeating-qtype has a simple but arguably partial fix: don't prepend the qtype to the query if the query already begins with the qtype.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1839684-repeating-qtype

This prevents duplicate prefixes, but a basic author search still shows as "author:mozart" in the searchbox. I wasn't immediately able to strip the query type from the search string for some reason, and there may be a case for keeping it (but not for duplicating it, of course).

[Gina Monti (gmonti90)]

I have tested the potential fix; it does prevent prefixes from duplicating when results are sorted. I sign off on this with my name Gina Monti. Email: <email address hidden>

[Mike Rylander (mrylander)]

Thanks, Jeff and Gina! Picked to master, 3.4 and 3.3.