Reports: transform selection is sticky

[Anna Goben]

Template field transform settings, once chosen in the selector, are sticky, even when it invalidates the datatype of other entries in the template editor. It travels as a sticky setting, despite not showing in the Transform box, into other sources being used to build the template until the person writing the report goes to an entry of the same type as the original was selected when the transform was chosen and deselects the transform. It should not be possible to apply a date transform to text or IDs or an average transform to text or IDs when writing/editing a template.

I've observed this behavior since 3.0. Currently using 3.1 on Chrome.

[Tiffany Little (tslittle)]

This is so aggravating, so I'm adding heat. I constantly forget that I need to double-check my transforms and then my report fails.

[Remington Steed (rjs7)]

This bug can cause transforms to be applied that aren't even in the list of choices for a field. For example, I was able to add a Boolean field (Item: Is Deleted) with a transform of "Month of Year", since I had chosen that transform on a previous field. However, the only transform available to Boolean fields is "Raw Data".

[Jennifer Bruch (jbruch)]

PaILS SPARK group is still experiencing this behavior on version 3.3.5 in Chrome

[Mike Rylander (mrylander)]

There is a branch available at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1778521-report-template-field-transform-sticky which resets the field transform each time fields are added to either tab.

[Dawn Dale (ddale)]

 have tested this code and consent to signing off on it with my name, Dawn Dale and my email address, <email address hidden>.

[Mike Rylander (mrylander)]

Thanks, Dawn!

I went ahead and committed this, backporting through 3.3.