Web Client - Archived Penalties/Messages does not Respect Date Range

[John Amundson]

Evergreen Web Client 3.0.8

From the Messages tab in a patron's account, Archived Penalties/Messages are displayed for the last year by default. In theory, older messages can be retrieved via editing the date range. However altering the date range does not update the list.

For example, today is 6/8/2018. By default, archived messages created between 6/8/2017 and 6/8/2018 are displayed. No matter how I edit or change the date range, I only ever see the messages created between 6/8/2017 and 6/8/2018.

In the XUL client, there was a "Retrieve Archived Penalties" command that does not exist in the web client.

[Eva Cerninakova (ece)]

Confirmed in Evergreen 3.3.2

[a. bellenir (abellenir)]

changing 'setQuery' to 'watchQuery' in archiveGrid seems to help.

https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/web/js/ui/default/staff/circ/patron/app.js;h=a886195050dd14c92948c0dfe04c1c8d1c30df5f;hb=refs/heads/master#l774

[Jason Stephenson (jstephenson)]

We implemented the fix suggested by a.bellenir on our Evergreen 3.4 test server at CW MARS, and it fixes the issue for us. Below is a branch that implements this fix with signoffs:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1775940-watchQuery-fix

[Galen Charlton (gmc)]

Pushed all the way to rel_3_3. Thanks, Jason and John!

I note that if a user types in the date input, the Javascript console will log a bunch of errors of the form "TypeError: $scope.dates.start_date is undefined". This is noisy, but I'm letting that go for now since at first glance it looks like a fix for that would be a little tricky if we want to avoid refreshing the grid while one of the date inputs is in an invalid state.