Web Client: Items Out - no colour to indicate that items are overdue

[Christine Burns]

EG3.1

Items Out - overdue items should be highlighted in red.

see related bug https://bugs.launchpad.net/evergreen/+bug/1635386

in xul client overdue items are highlighted in red on the items out interface.

[Kyle Huckins (khuckins)]

Branch pushed here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1635386-items-out-overdue-colors

Overdue items, whether Cataloged or Non-cataloged, are now highlighted in red when overdue.

[Bill Erickson (berick)]

I have confirmed Kyle's branch works as expected for standard overdue items. However, the additional logic to handle non-cat items is unnecessary and potentially confusing, since overdue non-cat items are never displayed anyway. My preference is for that part of the patch to be removed for clarity / simplicity.

[Kyle Huckins (khuckins)]

I've amended my previous commit with the suggested changes

[Kyle Huckins (khuckins)]

I noticed a couple thinkos - one in the branch name(it was reflecting the related task regarding the bills interface), and the other in the last commit in lp1635386. The CSS was applying a contrasting color to unvisited links, but not visited ones. New, essentially the same plus a CSS fix, branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1775286-items-out-overdue-colors

[Jennifer Pringle (jpringle-u)]

Fix is working as expected, regular items and pre-cats both show in red when overdue and go back to white when renewed.

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Pushed all the way to rel_3_3. Thanks, Kyle and Jennifer!

Noting that the color contrast with the red background meets WCAG AA but not WCAG AAA.