Patron Registration long Field Documentation display issue

Bug #1748277 reported by Kyle Huckins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Medium
Unassigned
3.1
Won't Fix
Undecided
Unassigned
3.2
Won't Fix
Undecided
Unassigned
3.3
Won't Fix
Undecided
Unassigned
3.4
Won't Fix
Medium
Unassigned
3.5
Won't Fix
Medium
Unassigned

Bug Description

In the Patron Edit/Registration field of the web client, when the field documentation string is too long, the div continues to flow horizontally, causing it to display underneath the z index of the patron registration fields, causing it to look a bit iffy and become partially unreadable. I've attached an image of the issue.

My gut leads me to believe this is a scaffolding issue.

Revision history for this message
Kyle Huckins (khuckins) wrote :
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

I've pushed up a branch here that should resolve this: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1748277-patron-reg-long-field-doc

It rescaffolds the patron editor, letting Bootstrap handle a bit more of the layout, and brings the z-index of the patron alert's pane up to 3, in order to avoid issues with the datepicker and any other input fields under form control.

Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
tags: added: pullrequest
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Revision history for this message
Galen Charlton (gmc) wrote :

Patch didn't apply, but I was able to rebase it:

user/gmcharlt/lp1748277-patron-reg-long-field-doc-rebase
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1748277-patron-reg-long-field-doc-rebase

Revision history for this message
Galen Charlton (gmc) wrote :

I note that with this patch, when you edit a new patron, the action bar is no longer fixed, though it remains fixed when you are editing an existing patron.

Revision history for this message
Galen Charlton (gmc) wrote :

Also, perhaps eg-help-popover should be used nowadays; the existing mechanism for displaying field documentation predated that directive.

Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Revision history for this message
Terran McCanna (tmccanna) wrote :

+1 to using the eg-help-popover instead

Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.1
importance: Undecided → Medium
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Revision history for this message
Terran McCanna (tmccanna) wrote :

Removing pullrequest as this would be better served with eg-help-popover

tags: added: needsrepatch
removed: pullrequest
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → none
tags: added: patron
removed: webstaffclient
tags: added: usability
tags: added: needswork
removed: needsrepatch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.