Remaining chunk/bundle work

[Mike Rylander]

Based on the following:

(master)$ gack max_chunk_count;gack 'max_chunk_size => 0'
Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
1447: max_chunk_count => 1
1790: max_chunk_count => 1
1847: max_chunk_count => 1

Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm
242: $client->max_chunk_count($self->{max_bundle_count}) if (!$client->can('max_bundle_count') && $self->{max_bundle_count});
806: $conn->max_chunk_count($self->{max_bundle_count}) if (!$conn->can('max_bundle_count') && $self->{max_bundle_count});
908: $conn->max_chunk_count(1) if (!$conn->can('max_bundle_size') && $conn->can('max_chunk_size') && $$args{report_all});
Open-ILS/src/perlmods/lib/OpenILS/Application/URLVerify.pm
38: max_chunk_size => 0,

Open-ILS/src/perlmods/lib/OpenILS/Application/HoldTargeter.pm
16: max_chunk_size => 0,

Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm
545: max_chunk_size => 0,

It looks like there are a couple places where we need to realign terminology, and we should probably do this for EG 3.0 since it will definitely require OpenSRF 2.5+ ... Specifically, I believe max_chunk_count needs to become max_bundle_count, and "max_chunk_size => 0" should become "max_bundle_count => 1" to have the desired effect.

I do not believe OpenSRF requires any change.

[Mike Rylander (mrylander)]

Note: This is unrelated to, but precipitated from initial investigation into, bug 1709710.

[Chris Sharp (chrissharp123)]

Here's a branch to implement these changes:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1710293_remaining_chunk_bundle_work

I have tested it lightly with no errors. I'd appreciate experienced eyes checking behind me.

[Chris Sharp (chrissharp123)]

Per Mike's recommendation I made some further removals of now-redundant code. Pushed to same branch.

[Chris Sharp (chrissharp123)]

Just squashed/rebased the branch and lightly tested. Same location:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1710293_remaining_chunk_bundle_work

[Jeff Davis (jdavis-sitka)]

Any chance of a test plan for this pullrequest?